GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/elog: Remove NULL check for array created in code 

Checking to see if a the location of a static variable is NULL isn't
super useful. If the check ever fails, there are much larger issues.

Found-by: Coverity Scan #1452607
Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I6d3e012542287511f61807075c998efd6d10441e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78614
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Martin Roth 2023-10-23 17:23:20 -06:00 committed by Martin L Roth
parent 27b4a60baf
commit 95c61c04c4
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/drivers/elog/elog.c
View File

@ -761,10 +761,6 @@ int elog_init(void)
elog_size = region_device_sz(&elog_state.nv_dev); elog_size = region_device_sz(&elog_state.nv_dev);
mirror_buffer = elog_mirror_buf; mirror_buffer = elog_mirror_buf;
if (!mirror_buffer) {
printk(BIOS_ERR, "ELOG: Unable to allocate backing store\n");
return -1;
}
rdev_chain_mem_rw(&elog_state.mirror_dev, mirror_buffer, elog_size); rdev_chain_mem_rw(&elog_state.mirror_dev, mirror_buffer, elog_size);
/* /*