GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpi: Comply with ACPI specification by making _STR unicode strings 

_STR should return Unicode string. From ACPI spec:
6.1.10 _STR (String)
The _STR object evaluates to an Unicode string that describes the
device or thermal zone.

BUG=NA
TEST=Check the changed _STR in SSDT to see if Unicode() macro is used

Signed-off-by: Cliff Huang <cliff.huang@intel.com>
Change-Id: I1f4b55a268c1dadbae456afe5821ae161b8e15a5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77695
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
This commit is contained in:
Cliff Huang 2023-09-07 09:39:37 -07:00 committed by Felix Held
parent 4c618cdd79
commit 95e4ffe848
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/acpi/acpigen_dptf.c
View File

@ -488,7 +488,7 @@ void dptf_write_STR(const char *str)
if (!str)
return;
acpigen_write_name_string("_STR", str);
acpigen_write_name_unicode("_STR", str);
}
void dptf_write_fan_options(bool fine_grained, int step_size, bool low_speed_notify)

2
src/drivers/acpi/thermal_zone/thermal_zone.c
View File

@ -61,7 +61,7 @@ static void thermal_zone_fill_ssdt(const struct device *dev)
acpigen_write_thermal_zone(name);
if (config->description)
acpigen_write_name_string("_STR", config->description);
acpigen_write_name_unicode("_STR", config->description);
if (config->polling_period)
acpigen_write_name_integer(

10
src/drivers/intel/dptf/dptf.c
View File

@ -112,7 +112,7 @@ static void dptf_write_generic_participant(const char *name,
acpigen_write_STA(sta_val);
if (str)
acpigen_write_name_string("_STR", str);
acpigen_write_name_unicode("_STR", str);
acpigen_write_name_integer("PTYP", ptype);
@ -143,7 +143,7 @@ static void write_fan(const struct drivers_intel_dptf_config *config,
acpigen_write_name("_HID");
dptf_write_hid(platform_info->use_eisa_hids, platform_info->fan_hid);
acpigen_write_name_integer("_UID", fan_uid++);
acpigen_write_name_string("_STR", DEFAULT_FAN_STR);
acpigen_write_name_unicode("_STR", DEFAULT_FAN_STR);
acpigen_write_name_integer("PTYP", DPTF_GENERIC_PARTICIPANT_TYPE_FAN);
acpigen_write_STA(get_STA_value(config, participant));
acpigen_pop_len(); /* Device */
@ -329,7 +329,7 @@ static void write_create_tpch(const struct dptf_platform_info *platform_info)
acpigen_write_device("TPCH");
acpigen_write_name("_HID");
dptf_write_hid(platform_info->use_eisa_hids, platform_info->tpch_device_hid);
acpigen_write_name_string("_STR", DEFAULT_TPCH_STR);
acpigen_write_name_unicode("_STR", DEFAULT_TPCH_STR);
acpigen_write_name_integer("PTYP", DPTF_GENERIC_PARTICIPANT_TYPE_TPCH);
acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
}
@ -402,7 +402,7 @@ static void write_create_tpwr(const struct drivers_intel_dptf_config *config,
if (platform_info->tpwr_device_hid != NULL)
dptf_write_hid(platform_info->use_eisa_hids, platform_info->tpwr_device_hid);
acpigen_write_name_string("_UID", "TPWR");
acpigen_write_name_string("_STR", DEFAULT_POWER_STR);
acpigen_write_name_unicode("_STR", DEFAULT_POWER_STR);
acpigen_write_name_integer("PTYP", DPTF_GENERIC_PARTICIPANT_TYPE_POWER);
acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
@ -429,7 +429,7 @@ static void write_create_tbat(const struct dptf_platform_info *platform_info)
if (platform_info->tbat_device_hid != NULL)
dptf_write_hid(platform_info->use_eisa_hids, platform_info->tbat_device_hid);
acpigen_write_name_string("_UID", "1");
acpigen_write_name_string("_STR", DEFAULT_BATTERY_STR);
acpigen_write_name_unicode("_STR", DEFAULT_BATTERY_STR);
acpigen_write_name_integer("PTYP", DPTF_GENERIC_PARTICIPANT_TYPE_BATTERY);
acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
acpigen_write_device_end(); /* TBAT Battery Participant Device */