From 9618cf436252095e68891d5a28e2c8b1b1ab6ac9 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Mon, 1 Jan 2018 14:36:49 +0100 Subject: [PATCH] cpu/via/car: ensure CAR ends up zeroed out MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We need to ensure the cache as ram area is set to all zeroes so that car_migrated works. Despite a comment claims the previous value is a test pattern it's actually not used for any testing. Drop the comment too. Change-Id: I1c91acbca8a860c2ed9c691d08d18718604682d8 Signed-off-by: Lubomir Rintel Reviewed-on: https://review.coreboot.org/25796 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Paul Menzel --- src/cpu/via/car/cache_as_ram.inc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/cpu/via/car/cache_as_ram.inc b/src/cpu/via/car/cache_as_ram.inc index 2c19453740..a131517cf4 100644 --- a/src/cpu/via/car/cache_as_ram.inc +++ b/src/cpu/via/car/cache_as_ram.inc @@ -149,12 +149,8 @@ clear_fixed_var_mtrr_out: movl %esi, %edi movl $(CacheSize >> 2), %ecx - /* - * 0x5c5c5c5c is a memory test pattern. - * TODO: Check if everything works with the zero pattern as well. - */ - /* xorl %eax, %eax */ - xorl $0x5c5c5c5c, %eax + /* Zero out the cache-as-ram area. */ + xorl %eax, %eax rep stosl #ifdef CARTEST