GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/i82801[ij]x: do not set Chipset Initialization Register (CIR) 5 

The specification updates for ICH 9 & 10 require to leave the
register in its default state by reserving all of its bits.
Writing to it does not seem to make a difference anyway since
reading it afterwards does not reflect the write (tested on ICH10).
Therefore we should omit the writes but document this fact in the
code because it is easy to miss from the datasheet alone.

Change-Id: Iec0d79f926a826a80b90907f7861d0cb2ca30a5b
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: https://review.coreboot.org/28094
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Stefan Tauner 2018-08-15 08:06:13 +02:00 committed by Patrick Georgi
parent cc68034ee9
commit 97c8089430
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/intel/i82801ix/i82801ix.c
View File

@ -46,7 +46,7 @@ static void i82801ix_early_settings(const config_t *const info)
RCBA32(RCBA_CIR9) = (RCBA32(RCBA_CIR9) & ~(0x3 << 26)) | (0x2 << 26);
RCBA32(RCBA_CIR7) = (RCBA32(RCBA_CIR7) & ~(0xf << 16)) | (0x5 << 16);
RCBA32(RCBA_CIR13) = (RCBA32(RCBA_CIR13) & ~(0xf << 16)) | (0x5 << 16);
RCBA32(RCBA_CIR5) |= (1 << 0);
/* RCBA32(RCBA_CIR5) |= (1 << 0); cf. Specification Update */
RCBA32(RCBA_CIR10) |= (3 << 16);
}

2
src/southbridge/intel/i82801jx/i82801jx.c
View File

@ -45,7 +45,7 @@ static void i82801jx_early_settings(const config_t *const info)
RCBA32(RCBA_CIR9) = (RCBA32(RCBA_CIR9) & ~(0x3 << 26)) | (0x2 << 26);
RCBA32(RCBA_CIR7) = (RCBA32(RCBA_CIR7) & ~(0xf << 16)) | (0x5 << 16);
RCBA32(RCBA_CIR13) = (RCBA32(RCBA_CIR13) & ~(0xf << 16)) | (0x5 << 16);
RCBA32(RCBA_CIR5) |= (1 << 0);
/* RCBA32(RCBA_CIR5) |= (1 << 0); cf. Specification Update */
RCBA32(RCBA_CIR10) |= (3 << 16);
}