From 98872649c51e5041c1c9589eb36fd1e97b0f3d49 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Fri, 22 Jan 2021 19:05:55 +0100 Subject: [PATCH] cpu/x86/mp_init.c: Print out the microcode revision of APs It is useful to know if MCU have been applied successfully. On the start of MP init lines similar to: "AP: slot 1 apic_id 1, MCU rev: 0x0700001d" will be printed. The example is taken from the log of an ocp/deltalake. Change-Id: Ia0a6428b41d07f87943f3aa7736b8cb457fdd15a Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/49840 Reviewed-by: Patrick Rudolph Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/cpu/x86/mp_init.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index c691c4882b..cca6093458 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -196,8 +196,12 @@ static void asmlinkage ap_init(unsigned int cpu) /* Fix up APIC id with reality. */ info->cpu->path.apic.apic_id = lapicid(); - printk(BIOS_INFO, "AP: slot %d apic_id %x.\n", cpu, - info->cpu->path.apic.apic_id); + if (cpu_is_intel()) + printk(BIOS_INFO, "AP: slot %d apic_id %x, MCU rev: 0x%08x\n", cpu, + info->cpu->path.apic.apic_id, get_current_microcode_rev()); + else + printk(BIOS_INFO, "AP: slot %d apic_id %x\n", cpu, + info->cpu->path.apic.apic_id); /* Walk the flight plan */ ap_do_flight_plan();