GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86/acpi.c: Be more verbose when finding the wakeup vector 

Since S3 resume sometimes breaks when trying to find the wakeup vector,
it is useful to log whether it errors or not. Since it is an error,
print it as such.

Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/29449
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Angel Pons 2018-11-04 12:25:25 +01:00 committed by Patrick Georgi
parent b93796d624
commit 98a68ada47
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/arch/x86/acpi.c
View File

@ -1278,8 +1278,11 @@ void *acpi_find_wakeup_vector(void)
break; break;
} }
if (rsdp == NULL) if (rsdp == NULL) {
printk(BIOS_ALERT,
"No RSDP found, wake up from S3 not possible.\n");
return NULL; return NULL;
}
printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp); printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp);
rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address; rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address;
@ -1294,15 +1297,18 @@ void *acpi_find_wakeup_vector(void)
fadt = NULL; fadt = NULL;
} }
if (fadt == NULL) if (fadt == NULL) {
printk(BIOS_ALERT,
"No FADT found, wake up from S3 not possible.\n");
return NULL; return NULL;
}
printk(BIOS_DEBUG, "FADT found at %p\n", fadt); printk(BIOS_DEBUG, "FADT found at %p\n", fadt);
facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl; facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl;
if (facs == NULL) { if (facs == NULL) {
printk(BIOS_DEBUG, "No FACS found, wake up from S3 not " printk(BIOS_ALERT,
"possible.\n"); "No FACS found, wake up from S3 not possible.\n");
return NULL; return NULL;
} }