GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb,soc/intel: Drop spurious SMI entry message 

The message only makes sense if ACPI PM base address is
allowed to be dynamic. If requested, it can be logged
in common code.

Change-Id: Iad7a60098c0391cc23384035af49e373dad90233
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70047
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Kyösti Mälkki 2022-11-25 09:07:56 +02:00
parent ac23f9da75
commit 99166482fe
6 changed files with 1 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/intel/baytrail/smm.c
View File

@ -27,8 +27,6 @@ void smm_southbridge_clear_state(void)
if (CONFIG(ELOG)) if (CONFIG(ELOG))
southcluster_log_state(); southcluster_log_state();
printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
printk(BIOS_SPEW, " pmbase = 0x%04x\n", get_pmbase());
smi_en = inl(get_pmbase() + SMI_EN); smi_en = inl(get_pmbase() + SMI_EN);
if (smi_en & APMC_EN) { if (smi_en & APMC_EN) {

3
src/soc/intel/braswell/smm.c
View File

@ -27,9 +27,6 @@ void smm_southbridge_clear_state(void)
if (CONFIG(ELOG)) if (CONFIG(ELOG))
southcluster_log_state(); southcluster_log_state();
printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
printk(BIOS_SPEW, " pmbase = 0x%04x\n", get_pmbase());
smi_en = inl(get_pmbase() + SMI_EN); smi_en = inl(get_pmbase() + SMI_EN);
if (smi_en & APMC_EN) { if (smi_en & APMC_EN) {
printk(BIOS_INFO, "SMI# handler already enabled?\n"); printk(BIOS_INFO, "SMI# handler already enabled?\n");

5
src/soc/intel/broadwell/pch/smi.c
View File

@ -14,17 +14,12 @@ void smm_southbridge_clear_state(void)
{ {
u32 smi_en; u32 smi_en;
printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", ACPI_BASE_ADDRESS);
smi_en = inl(ACPI_BASE_ADDRESS + SMI_EN); smi_en = inl(ACPI_BASE_ADDRESS + SMI_EN);
if (smi_en & APMC_EN) { if (smi_en & APMC_EN) {
printk(BIOS_INFO, "SMI# handler already enabled?\n"); printk(BIOS_INFO, "SMI# handler already enabled?\n");
return; return;
} }
printk(BIOS_DEBUG, "\n");
/* Dump and clear status registers */ /* Dump and clear status registers */
clear_smi_status(); clear_smi_status();
clear_pm1_status(); clear_pm1_status();

3
src/soc/intel/denverton_ns/smm.c
View File

@ -16,9 +16,6 @@ void smm_southbridge_clear_state(void)
{ {
uint32_t smi_en; uint32_t smi_en;
printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
printk(BIOS_SPEW, " pmbase = 0x%04x\n", get_pmbase());
smi_en = inl((uint16_t)(get_pmbase() + SMI_EN)); smi_en = inl((uint16_t)(get_pmbase() + SMI_EN));
if (smi_en & APMC_EN) { if (smi_en & APMC_EN) {
printk(BIOS_INFO, "SMI# handler already enabled?\n"); printk(BIOS_INFO, "SMI# handler already enabled?\n");

5
src/southbridge/intel/common/smi.c
View File

@ -23,15 +23,12 @@ static int smi_enabled(void)
if (CONFIG(ELOG)) if (CONFIG(ELOG))
pch_log_state(); pch_log_state();
printk(BIOS_DEBUG, "Initializing southbridge SMI...");
printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", lpc_get_pmbase());
smi_en = read_pmbase32(SMI_EN); smi_en = read_pmbase32(SMI_EN);
if (smi_en & APMC_EN) { if (smi_en & APMC_EN) {
printk(BIOS_INFO, "SMI# handler already enabled?\n"); printk(BIOS_INFO, "SMI# handler already enabled?\n");
return 1; return 1;
} }
printk(BIOS_DEBUG, "\n");
return 0; return 0;
} }

5
src/southbridge/intel/lynxpoint/smi.c
View File

@ -17,17 +17,12 @@ void smm_southbridge_clear_state(void)
if (CONFIG(ELOG)) if (CONFIG(ELOG))
pch_log_state(); pch_log_state();
printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", get_pmbase());
smi_en = inl(get_pmbase() + SMI_EN); smi_en = inl(get_pmbase() + SMI_EN);
if (smi_en & APMC_EN) { if (smi_en & APMC_EN) {
printk(BIOS_INFO, "SMI# handler already enabled?\n"); printk(BIOS_INFO, "SMI# handler already enabled?\n");
return; return;
} }
printk(BIOS_DEBUG, "\n");
/* Dump and clear status registers */ /* Dump and clear status registers */
clear_smi_status(); clear_smi_status();
clear_pm1_status(); clear_pm1_status();