soc/amd/*/config: drop invalid comment

Since commit 28e61f1634 ("device: Use __pci_0_00_0_config in
config_of_soc()") config_of_soc() was changed form being an actual
function to a macro for the __pci_0_00_0_config struct pointer generated
by util/sconfig. This change didn't only improve linker optimizations,
but also turned runtime errors into link-time errors, so it's guaranteed
that __pci_0_00_0_config won't be NULL and config_of_soc() won't
"return" NULL.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Id99ceaa9f7a70788da3f3068fb3da92d34fb6361
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70732
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
This commit is contained in:
Felix Held 2022-12-13 18:36:24 +01:00
parent 687ec6bd72
commit 993092039b
5 changed files with 0 additions and 5 deletions

View File

@ -6,7 +6,6 @@
const struct soc_amd_common_config *soc_get_common_config(void) const struct soc_amd_common_config *soc_get_common_config(void)
{ {
/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
const struct soc_amd_cezanne_config *cfg = config_of_soc(); const struct soc_amd_cezanne_config *cfg = config_of_soc();
return &cfg->common_config; return &cfg->common_config;
} }

View File

@ -6,7 +6,6 @@
const struct soc_amd_common_config *soc_get_common_config(void) const struct soc_amd_common_config *soc_get_common_config(void)
{ {
/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
const struct soc_amd_glinda_config *cfg = config_of_soc(); const struct soc_amd_glinda_config *cfg = config_of_soc();
return &cfg->common_config; return &cfg->common_config;
} }

View File

@ -8,7 +8,6 @@
const struct soc_amd_common_config *soc_get_common_config(void) const struct soc_amd_common_config *soc_get_common_config(void)
{ {
/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
const struct soc_amd_mendocino_config *cfg = config_of_soc(); const struct soc_amd_mendocino_config *cfg = config_of_soc();
return &cfg->common_config; return &cfg->common_config;
} }

View File

@ -6,7 +6,6 @@
const struct soc_amd_common_config *soc_get_common_config(void) const struct soc_amd_common_config *soc_get_common_config(void)
{ {
/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
const struct soc_amd_morgana_config *cfg = config_of_soc(); const struct soc_amd_morgana_config *cfg = config_of_soc();
return &cfg->common_config; return &cfg->common_config;
} }

View File

@ -6,7 +6,6 @@
const struct soc_amd_common_config *soc_get_common_config(void) const struct soc_amd_common_config *soc_get_common_config(void)
{ {
/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
const struct soc_amd_picasso_config *cfg = config_of_soc(); const struct soc_amd_picasso_config *cfg = config_of_soc();
return &cfg->common_config; return &cfg->common_config;
} }