google/auron: Clean up variant-specific romstage code

Use an empty weak function for variant_romstage_entry(), rather than
having separate empty functions for boards which don't utilize it.

Change-Id: I7a278ed716484bea377a5dd98d4a534502c8bab6
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/28612
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Matt DeVillier 2018-09-14 21:19:29 -05:00 committed by Martin Roth
parent 66a1e8d4e3
commit 99416035fa
3 changed files with 5 additions and 13 deletions

View File

@ -25,6 +25,10 @@
#include <variant/spd.h> #include <variant/spd.h>
#include "variant.h" #include "variant.h"
__weak void variant_romstage_entry(struct romstage_params *rp)
{
}
void mainboard_romstage_entry(struct romstage_params *rp) void mainboard_romstage_entry(struct romstage_params *rp)
{ {
struct pei_data pei_data; struct pei_data pei_data;
@ -43,6 +47,6 @@ void mainboard_romstage_entry(struct romstage_params *rp)
/* Call into the real romstage main with this board's attributes. */ /* Call into the real romstage main with this board's attributes. */
romstage_common(rp); romstage_common(rp);
/* Do variant-specific (read: Samus) init */ /* Do variant-specific init */
variant_romstage_entry(rp); variant_romstage_entry(rp);
} }

View File

@ -12,7 +12,6 @@
*/ */
#include <smbios.h> #include <smbios.h>
#include <soc/romstage.h>
#include <variant/onboard.h> #include <variant/onboard.h>
#include <mainboard/google/auron/variant.h> #include <mainboard/google/auron/variant.h>
@ -32,8 +31,3 @@ int variant_smbios_data(device_t dev, int *handle,
return len; return len;
} }
void variant_romstage_entry(struct romstage_params *rp)
{
/* N/A for boards other than SAMUS */
}

View File

@ -12,7 +12,6 @@
*/ */
#include <smbios.h> #include <smbios.h>
#include <soc/romstage.h>
#include <variant/onboard.h> #include <variant/onboard.h>
#include <mainboard/google/auron/variant.h> #include <mainboard/google/auron/variant.h>
@ -32,8 +31,3 @@ int variant_smbios_data(device_t dev, int *handle,
return len; return len;
} }
void variant_romstage_entry(struct romstage_params *rp)
{
/* N/A for boards other than SAMUS */
}