GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/amd/family_10h-family_15h: Remove variable set but not used 

Change-Id: Ifc63ec5b588f8edcec5eda343ec9694332845045
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33006
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Elyes HAOUAS 2019-05-25 11:47:56 +02:00 committed by Patrick Georgi
parent 4be1f8a2f6
commit 99f1d50335
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cpu/amd/family_10h-family_15h/init_cpus.c
View File

@ -986,7 +986,6 @@ void cpuSetAMDMSR(uint8_t node_id)
uint8_t nvram; uint8_t nvram;
u32 platform; u32 platform;
uint64_t revision; uint64_t revision;
uint8_t enable_c_states;
uint8_t enable_cpb; uint8_t enable_cpb;
printk(BIOS_DEBUG, "cpuSetAMDMSR "); printk(BIOS_DEBUG, "cpuSetAMDMSR ");
@ -1062,21 +1061,16 @@ void cpuSetAMDMSR(uint8_t node_id)
} }
if (revision & (AMD_DR_Ex | AMD_FAM15_ALL)) { if (revision & (AMD_DR_Ex | AMD_FAM15_ALL)) {
enable_c_states = 0;
if (CONFIG(HAVE_ACPI_TABLES)) if (CONFIG(HAVE_ACPI_TABLES))
if (get_option(&nvram, "cpu_c_states") == CB_SUCCESS) if ((get_option(&nvram, "cpu_c_states") == CB_SUCCESS) &&
enable_c_states = !!nvram; (nvram)) {
if (enable_c_states) {
/* Set up the C-state base address */ /* Set up the C-state base address */
msr_t c_state_addr_msr; msr_t c_state_addr_msr;
c_state_addr_msr = rdmsr(MSR_CSTATE_ADDRESS); c_state_addr_msr = rdmsr(MSR_CSTATE_ADDRESS);
c_state_addr_msr.lo = ACPI_CPU_P_LVL2; /* CstateAddr = ACPI_CPU_P_LVL2 */ c_state_addr_msr.lo = ACPI_CPU_P_LVL2;
wrmsr(MSR_CSTATE_ADDRESS, c_state_addr_msr); wrmsr(MSR_CSTATE_ADDRESS, c_state_addr_msr);
} }
} }
#else
enable_c_states = 0;
#endif #endif
if (revision & AMD_FAM15_ALL) { if (revision & AMD_FAM15_ALL) {