GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/pi/amd_late_init.c: Fix part number 

Kahlee DIMM have invalid string when it comes to part number
(bytes 0x149-0x15c). We currently force a NA string, but grunt has the
proper strings. Just let the string go through, and a second commit
within smbios.c will be responsible for testing the string and taking
proper action.

BUG=b:73122207
TEST=Build, boot and record serial output for kahlee while injecting
different strings to dmi17->PartNumber. Remove string injection before
committing.

Change-Id: I427262873f9ec80f459245e5f509e28a68de3074
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/23825
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Richard Spiegel 2018-02-20 08:35:39 -07:00 committed by Patrick Georgi
parent 3ca534f302
commit 99fd08d324
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/pi/amd_late_init.c
View File

@ -49,8 +49,8 @@ static void transfer_memory_info(TYPE17_DMI_INFO *dmi17, struct dimm_info *dimm)
dimm->bus_width = dmi17->DataWidth; dimm->bus_width = dmi17->DataWidth;
dimm->mod_id = dmi17->ManufacturerIdCode; dimm->mod_id = dmi17->ManufacturerIdCode;
dimm->bank_locator = 0; dimm->bank_locator = 0;
strncpy((char *)dimm->module_part_number, "NA", strncpy((char *)dimm->module_part_number, dmi17->PartNumber,
sizeof(dimm->module_part_number)); sizeof(dimm->module_part_number));
} }
static void prepare_dmi_17(void *unused) static void prepare_dmi_17(void *unused)