GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp/skx: Simplify pci_domain_read_resource 

Use a simpler pci_domain_read_resource for the stacks. This
makes it the same as the cpx function, since both get the stack
information from the FSP.

This will be merged with common xeon cpx/skx in a later patch.

Change-Id: I0130ce671fe9ff04e48021a0c5841551210aa827
Signed-off-by: Marc Jones <marcjones@sysproconsulting.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46308
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Jonathan Zhang <jonzhang@fb.com>
Reviewed-by: Jay Talbott <JayTalbott@sysproconsulting.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Marc Jones 2020-10-11 14:43:55 -06:00 committed by Marc Jones
parent 0262ffa85c
commit 9a0d4f8620
1 changed files with 14 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
src/soc/intel/xeon_sp/skx/chip.c
View File

@ -405,44 +405,6 @@ static void assign_stack_resources(struct iiostack_resource *stack_list,
} }
} }
static void xeonsp_constrain_pci_resources(struct device *dev, struct resource *res, void *data)
{
STACK_RES *stack = (STACK_RES *) data;
if (!(res->flags & IORESOURCE_FIXED))
return;
uint64_t base, limit;
if (res->flags & IORESOURCE_IO) {
base = stack->PciResourceIoBase;
limit = stack->PciResourceIoLimit;
} else if ((res->flags & IORESOURCE_MEM) && (res->flags & IORESOURCE_PCI64)) {
base = stack->PciResourceMem64Base;
limit = stack->PciResourceMem64Limit;
} else {
base = stack->PciResourceMem32Base;
limit = stack->PciResourceMem32Limit;
}
if (((res->base + res->size - 1) < base) || (res->base > limit)) /* outside window */
return;
if (res->limit > limit) /* resource end is out of limit */
limit = res->base - 1;
else
base = res->base + res->size;
if (res->flags & IORESOURCE_IO) {
stack->PciResourceIoBase = base;
stack->PciResourceIoLimit = limit;
} else if ((res->flags & IORESOURCE_MEM) && (res->flags & IORESOURCE_PCI64)) {
stack->PciResourceMem64Base = base;
stack->PciResourceMem64Limit = limit;
} else {
stack->PciResourceMem32Base = base;
stack->PciResourceMem32Limit = limit;
}
}
static void xeonsp_pci_domain_read_resources(struct device *dev) static void xeonsp_pci_domain_read_resources(struct device *dev)
{ {
struct bus *link; struct bus *link;
@ -464,18 +426,21 @@ static void xeonsp_pci_domain_read_resources(struct device *dev)
for (link = dev->link_list; link; link = link->next) for (link = dev->link_list; link; link = link->next)
xeonsp_pci_dev_iterator(link, xeonsp_reset_pci_op, NULL, NULL); xeonsp_pci_dev_iterator(link, xeonsp_reset_pci_op, NULL, NULL);
/*
* 1. group devices, resources for each stack
* 2. order resources in descending order of requested resource allocation sizes
*/
struct iiostack_resource stack_info = {0}; struct iiostack_resource stack_info = {0};
get_iiostack_info(&stack_info); uint8_t pci64bit_alloc_flag = get_iiostack_info(&stack_info);
if (!pci64bit_alloc_flag) {
/* constrain stack window */ /*
for (link = dev->link_list; link; link = link->next) { * Split 32 bit address space between prefetchable and
STACK_RES *stack = find_stack_for_bus(&stack_info, link->secondary); * non-prefetchable windows
assert(stack != 0); */
xeonsp_pci_dev_iterator(link, NULL, xeonsp_constrain_pci_resources, stack); for (int s = 0; s < stack_info.no_of_stacks; ++s) {
STACK_RES *res = &stack_info.res[s];
uint64_t length = (res->PciResourceMem32Limit -
res->PciResourceMem32Base + 1)/2;
res->PciResourceMem64Limit = res->PciResourceMem32Limit;
res->PciResourceMem32Limit = (res->PciResourceMem32Base + length - 1);
res->PciResourceMem64Base = res->PciResourceMem32Limit + 1;
}
} }
/* assign resources */ /* assign resources */