From 9ab02cb5fc86297bfcd52d266a07c95b8ee3d6e9 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Tue, 13 Oct 2020 13:56:25 +0200 Subject: [PATCH] soc/intel/broadwell/finalize.c: Use register names Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical. Change-Id: Ida1266f52fcc06577bd876f2cf3e3324ced6ab9d Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/46338 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/soc/intel/broadwell/finalize.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/soc/intel/broadwell/finalize.c b/src/soc/intel/broadwell/finalize.c index b795f46ce2..af720740af 100644 --- a/src/soc/intel/broadwell/finalize.c +++ b/src/soc/intel/broadwell/finalize.c @@ -27,17 +27,17 @@ static void broadwell_systemagent_finalize(void) { struct device *const host_bridge = pcidev_path_on_root(SA_DEVFN_ROOT); - pci_or_config16(host_bridge, 0x50, 1 << 0); /* GGC */ - pci_or_config32(host_bridge, 0x5c, 1 << 0); /* DPR */ - pci_or_config32(host_bridge, 0x78, 1 << 10); /* ME */ - pci_or_config32(host_bridge, 0x90, 1 << 0); /* REMAPBASE */ - pci_or_config32(host_bridge, 0x98, 1 << 0); /* REMAPLIMIT */ - pci_or_config32(host_bridge, 0xa0, 1 << 0); /* TOM */ - pci_or_config32(host_bridge, 0xa8, 1 << 0); /* TOUUD */ - pci_or_config32(host_bridge, 0xb0, 1 << 0); /* BDSM */ - pci_or_config32(host_bridge, 0xb4, 1 << 0); /* BGSM */ - pci_or_config32(host_bridge, 0xb8, 1 << 0); /* TSEGMB */ - pci_or_config32(host_bridge, 0xbc, 1 << 0); /* TOLUD */ + pci_or_config16(host_bridge, GGC, 1 << 0); + pci_or_config32(host_bridge, DPR, 1 << 0); + pci_or_config32(host_bridge, MESEG_LIMIT, 1 << 10); + pci_or_config32(host_bridge, REMAPBASE, 1 << 0); + pci_or_config32(host_bridge, REMAPLIMIT, 1 << 0); + pci_or_config32(host_bridge, TOM, 1 << 0); + pci_or_config32(host_bridge, TOUUD, 1 << 0); + pci_or_config32(host_bridge, BDSM, 1 << 0); + pci_or_config32(host_bridge, BGSM, 1 << 0); + pci_or_config32(host_bridge, TSEG, 1 << 0); + pci_or_config32(host_bridge, TOLUD, 1 << 0); MCHBAR32(0x50fc) |= 0x8f; /* MC */ MCHBAR32(0x5500) |= 1 << 0; /* PAVP */