GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/romcc: Prevent out-of-bounds read 

If 'class > LAST_REGC', then there will be an out-of-bounds read when
accessing 'regcm_bound'. Prevent this by skipping to the next iteration
of the loop. Note that this should not generally happen anyway, since
'result' represents a bitset for the indices of 'regcm_bound', and so
iterations where 'class > LAST_REGC' should already be skipped by the
previous continue statement (since those bits of 'result' should all be
zero).

Found-by: Covericy CID 1129122
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Change-Id: Id5f5adb0a292763251054aeecf2a5b87a11297b1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32902
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Jacob Garber 2019-05-20 16:35:33 -06:00 committed by Patrick Georgi
parent b6ee05692d
commit 9b0d8e7a1f
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
util/romcc/romcc.c
View File

@ -22160,6 +22160,7 @@ static unsigned arch_regcm_normalize(struct compile_state *state, unsigned regcm
} }
if (class > LAST_REGC) { if (class > LAST_REGC) {
result &= ~mask; result &= ~mask;
continue;
} }
for(class2 = 0; class2 <= LAST_REGC; class2++) { for(class2 = 0; class2 <= LAST_REGC; class2++) {
if ((regcm_bound[class2].first >= regcm_bound[class].first) && if ((regcm_bound[class2].first >= regcm_bound[class].first) &&