From 9b0de7145927f0158de3fe526ff34e298fdae793 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Sun, 29 Dec 2013 18:45:23 +0100 Subject: [PATCH] buildsystem: check for coreboot toolchain by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Other toolchains just don't cut it. Change-Id: I7a0bdf60d89b5166c9a22c9e9f3f326b28f777b8 Signed-off-by: Patrick Georgi Reviewed-on: http://review.coreboot.org/4584 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Paul Menzel Reviewed-by: Alexandru Gagniuc Reviewed-by: Stefan Reinauer --- Makefile.inc | 12 ++++++++++++ src/Kconfig | 10 ++++++++++ 2 files changed, 22 insertions(+) diff --git a/Makefile.inc b/Makefile.inc index fcd680df2b..90a50aa4aa 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -23,6 +23,18 @@ export KERNELVERSION := $(shell if [ -d "$(top)/.git" -a -f "`which git`" ]; \ then git describe --dirty --always || git describe; \ else echo 4.0$(KERNELREVISION); fi) +####################################################################### +# Test for coreboot toolchain (except when explicitely not requested) +ifneq ($(NOCOMPILE),1) +# only run if we're doing a build (not for tests, kconfig, ...) +ifneq ($(CONFIG_ANY_TOOLCHAIN),y) +_toolchain=$(shell $(CC_i386) -v 2>&1 |grep -q "gcc version .*coreboot toolchain" && echo coreboot) +ifneq ($(_toolchain),coreboot) +$(error Please use the coreboot toolchain (or prove that your toolchain works)) +endif +endif +endif + ####################################################################### # Basic component discovery MAINBOARDDIR=$(call strip_quotes,$(CONFIG_MAINBOARD_DIR)) diff --git a/src/Kconfig b/src/Kconfig index 2f5270e918..27f532b44e 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -70,6 +70,16 @@ config COMPILER_LLVM_CLANG endchoice +config ANY_TOOLCHAIN + bool "Allow building with any toolchain" + default n + depends on COMPILER_GCC + help + Many toolchains break when building coreboot since it uses quite + unusual linker features. Unless developers explicitely request it, + we'll have to assume that they use their distro compiler by mistake. + Make sure that using patched compilers is a conscious decision. + config SCANBUILD_ENABLE bool "Build with scan-build for static code analysis" default n