GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/thread: Rename thread_cooperate and thread_prevent_coop 

Renaming them to thread_coop_disable()/thread_coop_enable() makes them
sound like a pair.

BUG=b:179699789
TEST=Boot guybrush to OS

Suggested-by: Julius Werner <jwerner@chromium.org>
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I1d70c18965f53e733e871ca03107270612efa4fc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56357
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Raul E Rangel 2021-07-15 17:34:05 -06:00 committed by Raul Rangel
parent be60a0ddb0
commit 9ba36abdc5
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/include/thread.h
View File

@ -50,8 +50,8 @@ int thread_yield_microseconds(unsigned int microsecs);
* not occur. The critical sections can be nested. Just make sure the methods * not occur. The critical sections can be nested. Just make sure the methods
* are used in pairs. * are used in pairs.
*/ */
void thread_cooperate(void); void thread_coop_enable(void);
void thread_prevent_coop(void); void thread_coop_disable(void);
static inline void thread_init_cpu_info_non_bsp(struct cpu_info *ci) static inline void thread_init_cpu_info_non_bsp(struct cpu_info *ci)
{ {
@ -81,8 +81,8 @@ static inline int thread_yield_microseconds(unsigned int microsecs)
{ {
return -1; return -1;
} }
static inline void thread_cooperate(void) {} static inline void thread_coop_enable(void) {}
static inline void thread_prevent_coop(void) {} static inline void thread_coop_disable(void) {}
struct cpu_info; struct cpu_info;
static inline void thread_init_cpu_info_non_bsp(struct cpu_info *ci) { } static inline void thread_init_cpu_info_non_bsp(struct cpu_info *ci) { }
#endif #endif

6
src/lib/thread.c
View File

@ -114,7 +114,7 @@ static inline void free_thread(struct thread *t)
static void idle_thread(void *unused) static void idle_thread(void *unused)
{ {
/* This thread never voluntarily yields. */ /* This thread never voluntarily yields. */
thread_prevent_coop(); thread_coop_disable();
while (1) while (1)
timers_run(); timers_run();
} }
@ -352,7 +352,7 @@ int thread_yield_microseconds(unsigned int microsecs)
return 0; return 0;
} }
void thread_cooperate(void) void thread_coop_enable(void)
{ {
struct thread *current; struct thread *current;
@ -366,7 +366,7 @@ void thread_cooperate(void)
current->can_yield++; current->can_yield++;
} }
void thread_prevent_coop(void) void thread_coop_disable(void)
{ {
struct thread *current; struct thread *current;