From 9baffae485a7008ddc232b90126fe43615d61269 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20=C5=BBygowski?= Date: Thu, 29 Sep 2022 13:29:02 +0200 Subject: [PATCH] soc/intel/cmn/gfx: Add missing CML-U IGD device IDs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel Core i5-10210U can have the following IGD Device IDs 0x9B21/0x9B41/0x9BAC/0x9BCA/0x9BCC according to Intel ARK. Some of these IDs were not present in coreboot source nor hooked to the common graphics driver. Add the missing IDs so that the graphics driver will probe on the mentioned processor and detect the framebuffer. TEST=Boot Protectli VP4650 with i5-10210U and see framebuffer is detected when using FSP GOP and libgfxinit. Signed-off-by: Michał Żygowski Change-Id: Iee720a272367aead31c8c8fa712bade1b6e53948 Reviewed-on: https://review.coreboot.org/c/coreboot/+/67975 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/include/device/pci_ids.h | 2 ++ src/soc/intel/cannonlake/bootblock/report_platform.c | 2 ++ src/soc/intel/common/block/graphics/graphics.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 434449ccba..3da7410016 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3925,7 +3925,9 @@ #define PCI_DID_INTEL_CML_GT1_ULT_3 0x9B2B #define PCI_DID_INTEL_CML_GT1_ULT_4 0x9B2C #define PCI_DID_INTEL_CML_GT2_ULT_5 0x9BAA +#define PCI_DID_INTEL_CML_GT2_ULT_8 0x9BAC #define PCI_DID_INTEL_CML_GT2_ULT_6 0x9BCA +#define PCI_DID_INTEL_CML_GT2_ULT_7 0x9BCC #define PCI_DID_INTEL_CML_GT2_ULT_3 0x9B4B #define PCI_DID_INTEL_CML_GT2_ULT_4 0x9B4C #define PCI_DID_INTEL_CML_GT1_ULX_1 0x9B20 diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index c168431b03..fe362719c7 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -140,6 +140,8 @@ static struct { { PCI_DID_INTEL_CML_GT2_ULT_4, "CometLake ULT GT2" }, { PCI_DID_INTEL_CML_GT2_ULT_5, "CometLake ULT GT2" }, { PCI_DID_INTEL_CML_GT2_ULT_6, "CometLake ULT GT2" }, + { PCI_DID_INTEL_CML_GT2_ULT_7, "CometLake ULT GT2" }, + { PCI_DID_INTEL_CML_GT2_ULT_8, "CometLake ULT GT2" }, { PCI_DID_INTEL_CML_GT1_ULX_1, "CometLake ULX GT1" }, { PCI_DID_INTEL_CML_GT2_ULX_1, "CometLake ULX GT2" }, { PCI_DID_INTEL_CML_GT1_S_1, "CometLake S GT1" }, diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c index 30fc2c287b..98d19813a9 100644 --- a/src/soc/intel/common/block/graphics/graphics.c +++ b/src/soc/intel/common/block/graphics/graphics.c @@ -247,6 +247,8 @@ static const unsigned short pci_device_ids[] = { PCI_DID_INTEL_CML_GT1_ULT_4, PCI_DID_INTEL_CML_GT2_ULT_5, PCI_DID_INTEL_CML_GT2_ULT_6, + PCI_DID_INTEL_CML_GT2_ULT_7, + PCI_DID_INTEL_CML_GT2_ULT_8, PCI_DID_INTEL_CML_GT2_ULT_3, PCI_DID_INTEL_CML_GT2_ULT_4, PCI_DID_INTEL_CML_GT1_ULX_1,