GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/phoenix/early_fch: don't call enable_acpimmio_decode_pm04 

The enable_acpimmio_decode_pm04 function uses the IO port based indirect
access of the PM register space. The PM_INDEX and PM_DATA registers
don't exist any more on Phoenix, so the code shouldn't access those.
Since the PM_04_ACPIMMIO_DECODE_EN bit in the
ACPIMMIO_DECODE_REGISTER_04 register is 1 after reset, the ACPIMMIO
space is still accessible.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ia41f239b023edc094f5cbae63ed7c079649c74da
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76437
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2023-07-12 22:58:05 +02:00 committed by Martin L Roth
parent 7627208ad7
commit 9c0bce5f28
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/amd/phoenix/early_fch.c
View File

@ -19,9 +19,12 @@
/* Before console init */ /* Before console init */
void fch_pre_init(void) void fch_pre_init(void)
{ {
/* Enable_acpimmio_decode_pm04 to enable the ACPIMMIO decode which is needed to access /*
the GPIO registers. */ * PM_04_ACPIMMIO_DECODE_EN which enables the ACPIMMIO decode is already set after
enable_acpimmio_decode_pm04(); * reset. Since the IO port based indirect PM register space access isn't implemented
* in Phoenix any more, don't call enable_acpimmio_decode_pm04() which uses the
* indirect PM register space access via the IO ports that aren't implemented any more.
*/
/* Setup SPI base by calling lpc_early_init before setting up eSPI. */ /* Setup SPI base by calling lpc_early_init before setting up eSPI. */
lpc_early_init(); lpc_early_init();