From 9cae17d028d4bd3b278fc89ada8e06287917e213 Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Thu, 7 Oct 2021 16:22:51 +0200 Subject: [PATCH] mb/siemens/mc_ehl: Remove unneeded 'half_populated' variable Since the DRAM population is fixed to both channels on all mc_ehl boards there is no need to have this 'half_populated' variable at all. Simply use a fixed 'false' in the call of 'memcfg_init()' and delete this variable here. Change-Id: I783c17e6d92322a8b0c094cce803108e718011fa Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/coreboot/+/58177 Tested-by: build bot (Jenkins) Reviewed-by: Mario Scheithauer Reviewed-by: Paul Menzel --- src/mainboard/siemens/mc_ehl/romstage_fsp_params.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c index a6ed234170..f93e0affe8 100644 --- a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c +++ b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c @@ -17,9 +17,6 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) static uint8_t spd_data[0x100]; const char *cbfs_hwi_name = "hwinfo.hex"; - /* TODO: Read the resistor strap to get number of memory segments */ - bool half_populated = false; - /* Initialize SPD information for LPDDR4x from HW-Info primarily with a fallback to spd.bin in the case where the SPD data in HW-Info is not available or invalid. */ memset(spd_data, 0, sizeof(spd_data)); @@ -35,5 +32,5 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) spd_info.spd_spec.spd_index = 0x00; } /* Initialize variant specific configurations */ - memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, half_populated); + memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, false); }