Makefile.inc, payloads: Enable -Wvla
Variable length arrays are dangerous, so let's make sure they don't sneak back into coreboot or any of the payloads. Change-Id: Idf2488cf0efab51c9569a3789ae953368b61880c Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33846 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
f5238b243f
commit
9cd53c56ed
|
@ -402,7 +402,7 @@ endif
|
|||
CFLAGS_common += -pipe -g -nostdinc -std=gnu11
|
||||
CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes
|
||||
CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough
|
||||
CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits
|
||||
CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits -Wvla
|
||||
CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
|
||||
CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie
|
||||
ifeq ($(CONFIG_COMPILER_GCC),y)
|
||||
|
|
|
@ -83,7 +83,7 @@ OBJCOPY := $(OBJCOPY_$(ARCH-y))
|
|||
LPCC := CC="$(CC)" $(LIBPAYLOAD_OBJ)/bin/lpgcc
|
||||
LPAS := AS="$(AS)" $(LIBPAYLOAD_OBJ)/bin/lpas
|
||||
|
||||
CFLAGS += -Wall -Wextra -Wmissing-prototypes -Werror
|
||||
CFLAGS += -Wall -Wextra -Wmissing-prototypes -Wvla -Werror
|
||||
CFLAGS += -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES)
|
||||
|
||||
ifneq ($(strip $(HAVE_DOTCONFIG)),)
|
||||
|
|
|
@ -62,7 +62,7 @@ INCLUDES := -Iinclude -Iinclude/$(ARCHDIR-y) -I$(obj) -include include/kconfig.h
|
|||
CFLAGS += $(EXTRA_CFLAGS) $(INCLUDES) -Os -pipe -nostdinc -ggdb3
|
||||
CFLAGS += -nostdlib -fno-builtin -ffreestanding -fomit-frame-pointer
|
||||
CFLAGS += -ffunction-sections -fdata-sections
|
||||
CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes
|
||||
CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wvla
|
||||
CFLAGS += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough
|
||||
CFLAGS += -Wstrict-aliasing -Wshadow -Werror
|
||||
|
||||
|
|
|
@ -3,7 +3,7 @@ XCOMPILE=$(LIBPAYLOAD_DIR)/libpayload.xcompile
|
|||
# build libpayload and put .config file in $(CURDIR) instead of ../libpayload
|
||||
# to avoid pollute the libpayload source directory and possible conflicts
|
||||
LPOPTS=obj="$(CURDIR)/build" DESTDIR="$(CURDIR)" DOTCONFIG="$(CURDIR)/.config"
|
||||
CFLAGS += -Wall -Werror -Os -ffreestanding -nostdinc -nostdlib
|
||||
CFLAGS += -Wall -Wvla -Werror -Os -ffreestanding -nostdinc -nostdlib
|
||||
ifeq ($(CONFIG_ARCH_X86),y)
|
||||
TARGETARCH = i386
|
||||
endif
|
||||
|
|
|
@ -3,7 +3,7 @@ XCOMPILE=$(LIBPAYLOAD_DIR)/libpayload.xcompile
|
|||
# build libpayload and put .config file in $(CURDIR) instead of ../libpayload
|
||||
# to avoid pollute the libpayload source directory and possible conflicts
|
||||
LPOPTS=obj="$(CURDIR)/build" DESTDIR="$(CURDIR)" DOTCONFIG="$(CURDIR)/.config"
|
||||
CFLAGS += -Wall -Werror -Os -ffreestanding -nostdinc -nostdlib
|
||||
CFLAGS += -Wall -Wvla -Werror -Os -ffreestanding -nostdinc -nostdlib
|
||||
|
||||
all: nvramcui.elf
|
||||
|
||||
|
|
Loading…
Reference in New Issue