From 9cd96b409646418040f5c046a1366cfc38251d70 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Fri, 21 Feb 2014 12:43:07 +1100 Subject: [PATCH] vendorcode/amd/agesa/f*: Improve gcccar.inc assembler compatibility. A comparison with a two's complement in gcccar.inc has dubious GAS/AT&T notation. Clang miss-parses 0x-1 as an invalid hexadecimal number. Change-Id: I88baa5c2513f062ff309df05916a3832b9bd9bb1 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/5277 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/vendorcode/amd/agesa/f10/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f12/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f14/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f15/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f15tn/gcccar.inc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/vendorcode/amd/agesa/f10/gcccar.inc b/src/vendorcode/amd/agesa/f10/gcccar.inc index 61a8d3ee71..11f50dbae6 100644 --- a/src/vendorcode/amd/agesa/f10/gcccar.inc +++ b/src/vendorcode/amd/agesa/f10/gcccar.inc @@ -827,7 +827,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f12/gcccar.inc b/src/vendorcode/amd/agesa/f12/gcccar.inc index d7da81d1fc..22564cbdcc 100644 --- a/src/vendorcode/amd/agesa/f12/gcccar.inc +++ b/src/vendorcode/amd/agesa/f12/gcccar.inc @@ -821,7 +821,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f14/gcccar.inc b/src/vendorcode/amd/agesa/f14/gcccar.inc index 703734479b..40e0e31ce7 100644 --- a/src/vendorcode/amd/agesa/f14/gcccar.inc +++ b/src/vendorcode/amd/agesa/f14/gcccar.inc @@ -835,7 +835,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f15/gcccar.inc b/src/vendorcode/amd/agesa/f15/gcccar.inc index b20c77e575..c88709c7c4 100644 --- a/src/vendorcode/amd/agesa/f15/gcccar.inc +++ b/src/vendorcode/amd/agesa/f15/gcccar.inc @@ -842,7 +842,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f15tn/gcccar.inc b/src/vendorcode/amd/agesa/f15tn/gcccar.inc index c76ad163d6..d6dd49aff0 100644 --- a/src/vendorcode/amd/agesa/f15tn/gcccar.inc +++ b/src/vendorcode/amd/agesa/f15tn/gcccar.inc @@ -875,7 +875,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL