GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/smsc/lpc47b272/superio.c: Remove dead code 

Remove dead debug code, we have superiotool for this reason.
Restructure file to be consistent with other superio's thereby
avoiding forward declarations of functions.

Change-Id: I44272b4e30a2bc8c3a719df17b837432cd38429c
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8083
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Edward O'Callaghan 2015-01-04 16:35:43 +11:00
parent 520a328e5a
commit 9e687a62b1
1 changed files with 23 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

91
src/superio/smsc/lpc47b272/superio.c
View File

@ -34,15 +34,26 @@
#include <stdlib.h> #include <stdlib.h>
#include "lpc47b272.h" #include "lpc47b272.h"
/* Forward declarations */ /**
static void enable_dev(struct device *dev); * Initialize the specified Super I/O device.
static void lpc47b272_init(struct device *dev); *
// static void dump_pnp_device(struct device *dev); * Devices other than COM ports and the keyboard controller are ignored.
* For COM ports, we configure the baud rate.
*
* @param dev Pointer to structure describing a Super I/O device.
*/
static void lpc47b272_init(struct device *dev)
{
struct chip_operations superio_smsc_lpc47b272_ops = { if (!dev->enabled)
CHIP_NAME("SMSC LPC47B272 Super I/O") return;
.enable_dev = enable_dev
}; switch(dev->path.pnp.device) {
case LPC47B272_KBC:
pc_keyboard_init();
break;
}
}
static struct device_operations ops = { static struct device_operations ops = {
.read_resources = pnp_read_resources, .read_resources = pnp_read_resources,
@ -74,63 +85,7 @@ static void enable_dev(struct device *dev)
pnp_dev_info); pnp_dev_info);
} }
/** struct chip_operations superio_smsc_lpc47b272_ops = {
* Initialize the specified Super I/O device. CHIP_NAME("SMSC LPC47B272 Super I/O")
* .enable_dev = enable_dev
* Devices other than COM ports and the keyboard controller are ignored. };
* For COM ports, we configure the baud rate.
*
* @param dev Pointer to structure describing a Super I/O device.
*/
static void lpc47b272_init(struct device *dev)
{
if (!dev->enabled)
return;
switch(dev->path.pnp.device) {
case LPC47B272_KBC:
pc_keyboard_init();
break;
}
}
#if 0
/**
* Print the values of all of the LPC47B272's configuration registers.
*
* NOTE: The LPC47B272 must be in config mode when this function is called.
*
* @param dev Pointer to structure describing a Super I/O device.
*/
static void dump_pnp_device(struct device *dev)
{
int i;
print_debug("\n");
for (i = 0; i <= LPC47B272_MAX_CONFIG_REGISTER; i++) {
u8 register_value;
if ((i & 0x0f) == 0) {
print_debug_hex8(i);
print_debug_char(':');
}
/*
* Skip over 'register' that would cause exit from
* configuration mode.
*/
if (i == 0xaa)
register_value = 0xaa;
else
register_value = pnp_read_config(dev, i);
print_debug_char(' ');
print_debug_hex8(register_value);
if ((i & 0x0f) == 0x0f)
print_debug("\n");
}
print_debug("\n");
}
#endif