GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/lpc/espi_util: simplify espi_configure_decodes 

The intermediate ret variable isn't needed. espi_open_generic_io_window
only returns 0 or -1, so if ret is != 0, it has to be -1. This is a
preparation to use the enum cb_err type for the return values.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ia6c7f4cedf8c2defadcf4c4da1697a97c7b401f2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60206
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held 2021-12-18 00:41:23 +01:00
parent d992aa6111
commit 9e830540ec
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/amd/common/block/lpc/espi_util.c
View File

@ -300,17 +300,16 @@ static const struct espi_config *espi_get_config(void)
static int espi_configure_decodes(const struct espi_config *cfg) static int espi_configure_decodes(const struct espi_config *cfg)
{ {
int i, ret; int i;
espi_enable_decode(cfg->std_io_decode_bitmap); espi_enable_decode(cfg->std_io_decode_bitmap);
for (i = 0; i < ESPI_GENERIC_IO_WIN_COUNT; i++) { for (i = 0; i < ESPI_GENERIC_IO_WIN_COUNT; i++) {
if (cfg->generic_io_range[i].size == 0) if (cfg->generic_io_range[i].size == 0)
continue; continue;
ret = espi_open_generic_io_window(cfg->generic_io_range[i].base, if (espi_open_generic_io_window(cfg->generic_io_range[i].base,
cfg->generic_io_range[i].size); cfg->generic_io_range[i].size))
if (ret) return -1;
return ret;
} }
return 0; return 0;