arch/x86/car.ld: Remove AGESA linker warning workaround

Now that all AGESA codebases have been fixed to not use the .data
section, the warning workaround can be disabled.

Change-Id: I675d169a5d2f16e1e9ae05f95e045e9ef3d12208
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64401
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Martin L Roth <gaumless@tutanota.com>

src/arch/x86/car.ld

@@ -115,13 +115,8 @@ _rom_mtrr_base = _rom_mtrr_mask;
 
 . = 0xffffff00;
 .illegal_globals . : {
-#if CONFIG(AGESA_BROKEN_DATA_SECTION)
-	*(EXCLUDE_FILE ("*/libagesa.*.a:" "*/romstage*/buildOpts.o" "*/romstage*/agesawrapper.o" "*/vendorcode/amd/agesa/*" "*/vendorcode/amd/cimx/*") .data)
-	*(EXCLUDE_FILE ("*/libagesa.*.a:" "*/romstage*/buildOpts.o" "*/romstage*/agesawrapper.o" "*/vendorcode/amd/agesa/*" "*/vendorcode/amd/cimx/*") .data.*)
-#else
 	*(.data)
 	*(.data.*)
-#endif
 }
 
 _bogus = ASSERT((CONFIG_DCACHE_RAM_SIZE == 0) || (SIZEOF(.car.data) <= CONFIG_DCACHE_RAM_SIZE), "Cache as RAM area is too full");

src/northbridge/amd/agesa/Kconfig

@@ -27,13 +27,6 @@ config S3_VGA_ROM_RUN
 
 source "src/northbridge/amd/agesa/*/Kconfig"
 
-config AGESA_BROKEN_DATA_SECTION
-	bool
-	default y
-	help
-	  Select this on AGESA platforms that incorrectly use the .data
-	  section.
-
 # TODO: Reservation for heap seems excessive
 config HEAP_SIZE
 	hex

src/northbridge/amd/agesa/family14/Kconfig

@@ -17,7 +17,4 @@ config ECAM_MMCONF_BASE_ADDRESS
 config ECAM_MMCONF_BUS_NUMBER
 	default 64
 
-config AGESA_BROKEN_DATA_SECTION
-	default n
-
 endif # NORTHBRIDGE_AMD_AGESA_FAMILY14

src/northbridge/amd/agesa/family15tn/Kconfig

@@ -17,7 +17,4 @@ config ECAM_MMCONF_BASE_ADDRESS
 config ECAM_MMCONF_BUS_NUMBER
 	default 64
 
-config AGESA_BROKEN_DATA_SECTION
-	default n
-
 endif # NORTHBRIDGE_AMD_AGESA_FAMILY15_TN

src/northbridge/amd/agesa/family16kb/Kconfig

@@ -24,7 +24,4 @@ config VGA_BIOS_ID
 	  The default VGA BIOS PCI vendor/device ID should be set to the
 	  result of the map_oprom_vendev() function in northbridge.c.
 
-config AGESA_BROKEN_DATA_SECTION
-	default n
-
 endif # NORTHBRIDGE_AMD_AGESA_FAMILY16_KB