GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/tigerlake: Fix wrong operation region for CPU to PCH method 

CPU to PCH method refers to PCH ACPI operation region which was wrongly
defined as SystemIO. This causes ACPI AE_LIMIT error from PM _DSW
method. Change the operation region from SystemIO to SystemMemory to
resolve this execution failure.

BUG=b:140290596
TEST=Built and booted to kernel. _DSW method executes successfully without
ACPI AE_LIMIT error.

Signed-off-by: John Zhao <john.zhao@intel.com>
Change-Id: I3965c3d891f7d3cf4a448edc0c3f7e7749a905a1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41365
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
This commit is contained in:
John Zhao 2020-05-13 09:53:24 -07:00 committed by Patrick Georgi
parent 81a30ec3a7
commit 9e9f301b58
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/tigerlake/acpi/tcss.asl
View File

@ -45,10 +45,10 @@ Scope (\_SB)
} }
/* /*
* Define PCH ACPIBASE I/O as an ACPI operating region. The base address can be * Define PCH ACPIBASE as an ACPI operating region. The base address can be
* found in Device 31, Function 2, Offset 40h. * found in Device 31, Function 2, Offset 40h.
*/ */
OperationRegion (PMIO, SystemIO, PCH_PWRM_BASE_ADDRESS, 0x80) OperationRegion (PMIO, SystemMemory, PCH_PWRM_BASE_ADDRESS, 0x80)
Field (PMIO, ByteAcc, NoLock, Preserve) { Field (PMIO, ByteAcc, NoLock, Preserve) {
Offset(0x6C), /* 0x6C, General Purpose Event 0 Status [127:96] */ Offset(0x6C), /* 0x6C, General Purpose Event 0 Status [127:96] */
, 19, , 19,
@ -74,7 +74,7 @@ Scope (\_SB)
*/ */
Method (C2PM, 4, NotSerialized) Method (C2PM, 4, NotSerialized)
{ {
Local0 = 0x1 << Arg3 Local0 = 1 << Arg3
/* This method is used to enable/disable wake from Tcss Device (WKEN). */ /* This method is used to enable/disable wake from Tcss Device (WKEN). */
If (Arg0 && Arg1) If (Arg0 && Arg1)
{ /* If entering Sx and enabling wake, need to enable WAKE capability. */ { /* If entering Sx and enabling wake, need to enable WAKE capability. */

2
src/soc/intel/tigerlake/acpi/tcss_pcierp.asl
View File

@ -64,7 +64,7 @@ Field (PXCS, AnyAcc, NoLock, WriteAsZeros)
*/ */
Method (_DSM, 4, Serialized) Method (_DSM, 4, Serialized)
{ {
return (Buffer() {0x00}) Return (Buffer() {0x00})
} }
Device (PXSX) Device (PXSX)