GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

smmstore: make smmstore's SMM handler code follow everything else 

Instead of SMMSTORE_APM_CNT use APM_CNT_SMMSTORE and define it in
cpu/x86/smm.h

Change-Id: Iabc0c9662284ed3ac2933001e64524011a5bf420
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/30023
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Georgi 2018-12-03 16:13:17 +01:00
parent d61839c3ea
commit 9fca297ca4
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/include/cpu/x86/smm.h
View File

@ -473,6 +473,7 @@ typedef struct {
#define APM_CNT_GNVS_UPDATE 0xea
#define APM_CNT_FINALIZE 0xcb
#define APM_CNT_LEGACY 0xcc
#define APM_CNT_SMMSTORE 0xed
#define APM_CNT_ELOG_GSMI 0xef
#define APM_STS 0xb3

2
src/include/smmstore.h
View File

@ -19,8 +19,6 @@
#include <stddef.h>
#include <stdint.h>
#define SMMSTORE_APM_CNT 0xed
#define SMMSTORE_RET_SUCCESS 0
#define SMMSTORE_RET_FAILURE 1
#define SMMSTORE_RET_UNSUPPORTED 2

4
src/soc/intel/common/block/smm/smihandler.c
View File

@ -301,7 +301,7 @@ static void southbridge_smi_store(
void *io_smi;
uint32_t reg_ebx;
io_smi = find_save_state(save_state_ops, SMMSTORE_APM_CNT);
io_smi = find_save_state(save_state_ops, APM_CNT_SMMSTORE);
if (!io_smi)
return;
/* Command and return value in EAX */
@ -391,7 +391,7 @@ void smihandler_southbridge_apmc(
if (IS_ENABLED(CONFIG_ELOG_GSMI))
southbridge_smi_gsmi(save_state_ops);
break;
case SMMSTORE_APM_CNT:
case APM_CNT_SMMSTORE:
if (IS_ENABLED(CONFIG_SMMSTORE))
southbridge_smi_store(save_state_ops);
break;