From a006259e6f6b09b388dd7fa0669c84bdeaea951b Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 12 Dec 2022 07:01:44 +0100 Subject: [PATCH] mb/google/slippy/acpi: Replace Store(a,b) with ASL 2.0 syntax Replace `Store (a, b)` with `b = a`. Change-Id: I950d776a712a104f2caed614886ce2527028ead7 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/70681 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas Reviewed-by: Eric Lai --- src/mainboard/google/slippy/acpi/platform.asl | 8 ++++---- src/mainboard/google/slippy/acpi/thermal.asl | 8 ++++---- .../variants/falco/include/variant/acpi/mainboard.asl | 2 +- .../variants/leon/include/variant/acpi/mainboard.asl | 2 +- .../variants/peppy/include/variant/acpi/mainboard.asl | 6 +++--- .../variants/wolf/include/variant/acpi/mainboard.asl | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/mainboard/google/slippy/acpi/platform.asl b/src/mainboard/google/slippy/acpi/platform.asl index 010ee9bae3..c98fc6e5c7 100644 --- a/src/mainboard/google/slippy/acpi/platform.asl +++ b/src/mainboard/google/slippy/acpi/platform.asl @@ -15,16 +15,16 @@ Method(_PTS,1) Method(_WAK,1) { /* Update AC status */ - Store (\_SB.PCI0.LPCB.EC0.ACEX, Local0) + Local0 = \_SB.PCI0.LPCB.EC0.ACEX if (Local0 != \PWRS) { - Store (Local0, \PWRS) + \PWRS = Local0 Notify (\_SB.PCI0.LPCB.EC0.AC, 0x80) } /* Update LID status */ - Store (\_SB.PCI0.LPCB.EC0.LIDS, Local0) + Local0 = \_SB.PCI0.LPCB.EC0.LIDS if (Local0 != \LIDS) { - Store (Local0, \LIDS) + \LIDS = Local0 Notify (\_SB.PCI0.LPCB.EC0.LID0, 0x80) } diff --git a/src/mainboard/google/slippy/acpi/thermal.asl b/src/mainboard/google/slippy/acpi/thermal.asl index c71b8dbfce..38baad631b 100644 --- a/src/mainboard/google/slippy/acpi/thermal.asl +++ b/src/mainboard/google/slippy/acpi/thermal.asl @@ -64,7 +64,7 @@ Scope (\_TZ) Method (TCHK, 0, Serialized) { // Get Temperature from TIN# set in NVS - Store (\_SB.PCI0.LPCB.EC0.TINS (TMPS), Local0) + Local0 = \_SB.PCI0.LPCB.EC0.TINS (TMPS) // Check for sensor not calibrated If (Local0 == \_SB.PCI0.LPCB.EC0.TNCA) { @@ -97,10 +97,10 @@ Scope (\_TZ) Method (_TMP, 0, Serialized) { // Get temperature from EC in deci-kelvin - Store (TCHK (), Local0) + Local0 = TCHK () // Critical temperature in deci-kelvin - Store (CTOK (\TCRT), Local1) + Local1 = CTOK (\TCRT) If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0) @@ -109,7 +109,7 @@ Scope (\_TZ) Sleep (1000) // Re-read temperature from EC - Store (TCHK (), Local0) + Local0 = TCHK () Printf ("RE-READ TEMPERATURE: %o", Local0) } diff --git a/src/mainboard/google/slippy/variants/falco/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/falco/include/variant/acpi/mainboard.asl index 9e5140e842..ad4049e235 100644 --- a/src/mainboard/google/slippy/variants/falco/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/variants/falco/include/variant/acpi/mainboard.asl @@ -37,7 +37,7 @@ Scope (\_SB.PCI0.I2C0) Method (_DSW, 3, NotSerialized) { - Store (BOARD_TRACKPAD_WAKE_GPIO, Local0) + Local0 = BOARD_TRACKPAD_WAKE_GPIO If (Arg0 == 1) { // Enable GPIO as wake source \_SB.PCI0.LPCB.GPIO.GWAK (Local0) diff --git a/src/mainboard/google/slippy/variants/leon/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/leon/include/variant/acpi/mainboard.asl index 9d6631dfda..fbc40f1f93 100644 --- a/src/mainboard/google/slippy/variants/leon/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/variants/leon/include/variant/acpi/mainboard.asl @@ -37,7 +37,7 @@ Scope (\_SB.PCI0.I2C0) Method (_DSW, 3, NotSerialized) { - Store (BOARD_TRACKPAD_WAKE_GPIO, Local0) + Local0 = BOARD_TRACKPAD_WAKE_GPIO If (Arg0 == 1) { // Enable GPIO as wake source \_SB.PCI0.LPCB.GPIO.GWAK (Local0) diff --git a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl index ee30209851..e149901826 100644 --- a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl @@ -37,7 +37,7 @@ Scope (\_SB.PCI0.I2C0) Method (_DSW, 3, NotSerialized) { - Store (BOARD_TRACKPAD_WAKE_GPIO, Local0) + Local0 = BOARD_TRACKPAD_WAKE_GPIO If (Arg0 == 1) { // Enable GPIO as wake source \_SB.PCI0.LPCB.GPIO.GWAK (Local0) @@ -79,7 +79,7 @@ Scope (\_SB.PCI0.I2C0) Method (_DSW, 3, NotSerialized) { - Store (BOARD_TRACKPAD_WAKE_GPIO, Local0) + Local0 = BOARD_TRACKPAD_WAKE_GPIO If (Arg0 == 1) { // Enable GPIO as wake source \_SB.PCI0.LPCB.GPIO.GWAK (Local0) @@ -119,7 +119,7 @@ Scope (\_SB.PCI0.I2C1) Method (_DSW, 3, NotSerialized) { - Store (BOARD_TOUCHSCREEN_WAKE_GPIO, Local0) + Local0 = BOARD_TOUCHSCREEN_WAKE_GPIO If (Arg0 == 1) { // Enable GPIO as wake source \_SB.PCI0.LPCB.GPIO.GWAK (Local0) diff --git a/src/mainboard/google/slippy/variants/wolf/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/wolf/include/variant/acpi/mainboard.asl index 9d6631dfda..fbc40f1f93 100644 --- a/src/mainboard/google/slippy/variants/wolf/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/variants/wolf/include/variant/acpi/mainboard.asl @@ -37,7 +37,7 @@ Scope (\_SB.PCI0.I2C0) Method (_DSW, 3, NotSerialized) { - Store (BOARD_TRACKPAD_WAKE_GPIO, Local0) + Local0 = BOARD_TRACKPAD_WAKE_GPIO If (Arg0 == 1) { // Enable GPIO as wake source \_SB.PCI0.LPCB.GPIO.GWAK (Local0)