From a020903307b183a24e589b3f7d48ea0e598e3921 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Fri, 24 Jul 2020 12:42:59 -0600 Subject: [PATCH] util/lint/Kconfig_lint: Update Naked BOOL reference to error The lint-stable makefile target only watches for errors in the Kconfig file, so has not protected additional "Naked" references to BOOL type Kconfig symbols from entering the tree. Update it to an error so that they can't continue coming into the codebase. Signed-off-by: Martin Roth Change-Id: Icce2a9a627c4fbcaa220df18474cb8bfea8b2a8c Reviewed-on: https://review.coreboot.org/c/coreboot/+/43826 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- util/lint/kconfig_lint | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 8ee6416a31..2341976b41 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -332,7 +332,7 @@ sub check_config_macro { $line = $1 . $3; if ( exists $symbols{$symbol} ) { if ( $symbols{$symbol}{type} eq "bool" ) { - show_warning( "Naked reference to CONFIG_$symbol used at $file:$lineno." + show_error( "Naked reference to CONFIG_$symbol used at $file:$lineno." . " A 'bool' Kconfig should always be accessed through CONFIG($symbol)." ); } } else {