sb,soc/intel: Fix SMI handler IO trap data mask

Shift is done in multiples of 8 (1 << 3) bits.
It was fixed already for i82801ix/jx.

Change-Id: I5e1c2b3bf4ba68f34eb43e59fe783d5cd6e0a39a
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70361
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Kyösti Mälkki 2022-12-03 19:35:53 +02:00
parent 7a9bd2b2e4
commit a0720431b4
6 changed files with 6 additions and 6 deletions

View File

@ -429,7 +429,7 @@ static void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10); trap_cycle = RCBA32(0x1e10);
for (i = 16; i < 20; i++) { for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i)) if (trap_cycle & (1 << i))
mask |= (0xff << ((i - 16) << 2)); mask |= (0xff << ((i - 16) << 3));
} }
/* IOTRAP(3) SMI function call */ /* IOTRAP(3) SMI function call */

View File

@ -70,7 +70,7 @@ void smihandler_southbridge_monitor(
trap_cycle = pcr_read32(PID_PSTH, PCR_PSTH_TRPC); trap_cycle = pcr_read32(PID_PSTH, PCR_PSTH_TRPC);
for (i = 16; i < 20; i++) { for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i)) if (trap_cycle & (1 << i))
mask |= (0xff << ((i - 16) << 2)); mask |= (0xff << ((i - 16) << 3));
} }
/* IOTRAP(3) SMI function call */ /* IOTRAP(3) SMI function call */

View File

@ -100,7 +100,7 @@ void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10); trap_cycle = RCBA32(0x1e10);
for (i=16; i<20; i++) { for (i=16; i<20; i++) {
if (trap_cycle & (1 << i)) if (trap_cycle & (1 << i))
mask |= (0xff << ((i - 16) << 2)); mask |= (0xff << ((i - 16) << 3));
} }
/* IOTRAP(3) SMI function call */ /* IOTRAP(3) SMI function call */

View File

@ -49,7 +49,7 @@ void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10); trap_cycle = RCBA32(0x1e10);
for (i = 16; i < 20; i++) { for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i)) if (trap_cycle & (1 << i))
mask |= (0xff << ((i - 16) << 2)); mask |= (0xff << ((i - 16) << 3));
} }
/* IOTRAP(3) SMI function call */ /* IOTRAP(3) SMI function call */

View File

@ -85,7 +85,7 @@ void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10); trap_cycle = RCBA32(0x1e10);
for (i = 16; i < 20; i++) { for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i)) if (trap_cycle & (1 << i))
mask |= (0xff << ((i - 16) << 2)); mask |= (0xff << ((i - 16) << 3));
} }
/* IOTRAP(3) SMI function call */ /* IOTRAP(3) SMI function call */

View File

@ -393,7 +393,7 @@ static void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10); trap_cycle = RCBA32(0x1e10);
for (i = 16; i < 20; i++) { for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i)) if (trap_cycle & (1 << i))
mask |= (0xff << ((i - 16) << 2)); mask |= (0xff << ((i - 16) << 3));
} }
/* IOTRAP(3) SMI function call */ /* IOTRAP(3) SMI function call */