GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/rammus: rework method get_wifi_sar_cbfs_filename 

The return statement at the end of the method is never reached. Remove
it. Also while at it, assign the return value of variant_board_sku()
to ski_id while the variable declaration and make it const.

Signed-off-by: Yuchen He <yuchenhe126@gmail.com>
Change-Id: If05df8934f68ffec9ad21c88394055f71d618133
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73867
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
This commit is contained in:
Yuchen He 2023-03-22 00:34:35 +01:00 committed by Felix Singer
parent 7f5a52cc63
commit a0833959aa
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/google/poppy/variants/rammus/mainboard.c
View File

@ -33,13 +33,10 @@ const char *smbios_system_sku(void)
const char *get_wifi_sar_cbfs_filename(void)
{
uint32_t sku_id;
const uint32_t sku_id = variant_board_sku();
sku_id = variant_board_sku();
if (sku_id & 0x200)
return "wifi_sar-shyvana.hex";
else
return "wifi_sar-leona.hex";
return WIFI_SAR_CBFS_DEFAULT_FILENAME;
}