GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim: Do not pass recovery APCB 

If recovery APCB is not passed, amdfwtool will build amdfw*.rom with
AMD_BIOS_APCB_BK entry pointing to the same offset as AMD_BIOS_APCB
entry. This will help to save 40 KiB flash space in each FW slot. On
ChromeOS, this means saving ~120 KiB flash space.

BUG=b:240696002
TEST=Build and boot to OS in Skyrim.

Change-Id: Ib3bbc1eededae20b2cd48f514722a207c46536a0
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73662
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Karthikeyan Ramasubramanian 2023-03-09 17:54:14 -07:00 committed by Paul Fagerburg
parent 8d88561235
commit a18b8b44d7
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/skyrim/Makefile.inc
View File

@ -29,7 +29,6 @@ ifneq ($(wildcard $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memor
LIB_SPD_DEPS = $(SPD_SOURCES) LIB_SPD_DEPS = $(SPD_SOURCES)
APCB_SOURCES = $(obj)/$(APCB_NAME).gen APCB_SOURCES = $(obj)/$(APCB_NAME).gen
APCB_SOURCES_RECOVERY = $(obj)/$(APCB_NAME).gen
$(obj)/$(APCB_NAME).gen: $(SPD_SOURCES) \ $(obj)/$(APCB_NAME).gen: $(SPD_SOURCES) \
$(APCB_V3_EDIT_TOOL) \ $(APCB_V3_EDIT_TOOL) \