GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/amd/pi/00730F01/northbridge.c: Use 'pci_{and,or}_config' 

Change-Id: Ifd77c90fe82e20df91562fccea8b5d89dd4a193d
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62134
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
This commit is contained in:
Elyes Haouas 2022-02-17 18:14:08 +01:00 committed by Felix Held
parent e284ca26bf
commit a1f5ad0849
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/northbridge/amd/pi/00730F01/northbridge.c
View File

@ -682,8 +682,8 @@ static const struct pci_driver family10_northbridge __pci_driver = {
static void fam16_finalize(void *chip_info) static void fam16_finalize(void *chip_info)
{ {
struct device *dev; struct device *dev;
u32 value;
dev = pcidev_on_root(0, 0); /* clear IoapicSbFeatureEn */ dev = pcidev_on_root(0, 0); /* clear IoapicSbFeatureEn */
pci_write_config32(dev, 0xF8, 0); pci_write_config32(dev, 0xF8, 0);
pci_write_config32(dev, 0xFC, 5); /* TODO: move it to dsdt.asl */ pci_write_config32(dev, 0xFC, 5); /* TODO: move it to dsdt.asl */
@ -698,30 +698,24 @@ static void fam16_finalize(void *chip_info)
/* Select GPP link core IO Link Strap Control register 0xB0 */ /* Select GPP link core IO Link Strap Control register 0xB0 */
pci_write_config32(dev, 0xE0, 0x014000B0); pci_write_config32(dev, 0xE0, 0x014000B0);
value = pci_read_config32(dev, 0xE4);
/* Enable AER (bit 5) and ACS (bit 6 undocumented) */ /* Enable AER (bit 5) and ACS (bit 6 undocumented) */
value |= PCIE_CAP_AER | PCIE_CAP_ACS; pci_or_config32(dev, 0xE4, PCIE_CAP_AER | PCIE_CAP_ACS);
pci_write_config32(dev, 0xE4, value);
/* Select GPP link core Wrapper register 0x00 (undocumented) */ /* Select GPP link core Wrapper register 0x00 (undocumented) */
pci_write_config32(dev, 0xE0, 0x01300000); pci_write_config32(dev, 0xE0, 0x01300000);
value = pci_read_config32(dev, 0xE4);
/* /*
* Enable ACS capabilities straps including sub-items. From lspci it * Enable ACS capabilities straps including sub-items. From lspci it
* looks like these bits enable: Source Validation and Translation * looks like these bits enable: Source Validation and Translation
* Blocking * Blocking
*/ */
value |= (BIT(24) | BIT(25) | BIT(26)); pci_or_config32(dev, 0xE4, (BIT(24) | BIT(25) | BIT(26)));
pci_write_config32(dev, 0xE4, value);
/* disable No Snoop */ /* disable No Snoop */
dev = pcidev_on_root(1, 1); dev = pcidev_on_root(1, 1);
if (dev != NULL) { if (dev != NULL) {
value = pci_read_config32(dev, 0x60); pci_and_config32(dev, 0x60, ~(1 << 11));
value &= ~(1 << 11);
pci_write_config32(dev, 0x60, value);
} }
} }