GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/dram/ddr2: Add break to several case statements that lack it 

For all valid SPD values the same decoded tRR was returned.

Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Found-by: Coverity Scan #1381369, #1381370, 1381371, 1381372, 1381373
Reviewed-on: https://review.coreboot.org/21642
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Patrick Georgi 2017-09-22 18:21:52 +02:00 committed by Nico Huber
parent fdddc463ce
commit a2248cbf9a
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/device/dram/ddr2.c
View File

@ -194,16 +194,22 @@ static int spd_decode_tRR_time(u32 *tRR, u8 c)
return CB_ERR;
case 0x80:
*tRR = 15625 << 8;
break;
case 0x81:
*tRR = 15625 << 6;
break;
case 0x82:
*tRR = 15625 << 7;
break;
case 0x83:
*tRR = 15625 << 9;
break;
case 0x84:
*tRR = 15625 << 10;
break;
case 0x85:
*tRR = 15625 << 11;
break;
}
return CB_SUCCESS;
}