From a2503fa2e9c1c69495c29c4dfb00e7413952523d Mon Sep 17 00:00:00 2001 From: Solomon Alan-Dei Date: Sat, 29 Oct 2022 08:30:23 -0600 Subject: [PATCH] util/cbfstool/bpdt_formats: Fix memory leak issues The functions create_bpdt_hdr and create_cse_layout in bpdt_1_6.c are defined to return pointers but not integers as was previouly implemented. Reported-by: Coverity(CID:1469323) Reported-by: Coverity(CID:1469353) Signed-off-by: Solomon Alan-Dei Change-Id: Idb78d94be7a75a25ad954f062e9e52b1f0b921dc Reviewed-on: https://review.coreboot.org/c/coreboot/+/68986 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- util/cbfstool/bpdt_formats/bpdt_1_6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/cbfstool/bpdt_formats/bpdt_1_6.c b/util/cbfstool/bpdt_formats/bpdt_1_6.c index b894936543..c5cedd3d8b 100644 --- a/util/cbfstool/bpdt_formats/bpdt_1_6.c +++ b/util/cbfstool/bpdt_formats/bpdt_1_6.c @@ -69,7 +69,7 @@ static bpdt_hdr_ptr create_bpdt_hdr(void) h->fit_tool_version.build = 0; h->fit_tool_version.hotfix = 0; - return 0; + return h; } static void print_bpdt_hdr(const bpdt_hdr_ptr ptr) @@ -159,7 +159,7 @@ static cse_layout_ptr create_cse_layout(const struct region *r) l->bp3_size = r[BP3].size; l->checksum = 0; /* unused */ - return 0; + return l; } static void print_cse_layout(const cse_layout_ptr ptr)