mb, soc/intel: Switch to using drivers/wifi/generic for Intel WiFi devices

This change switches all mainboard devices to use drivers/wifi/generic
instead of drivers/intel/wifi chip driver for Intel WiFi
devices. There is no need for two separate chip drivers in coreboot to
handle Intel and non-Intel WiFi devices since the differences can be
handled at runtime using the PCI vendor ID. This also allows mainboard
to easily multi-source WiFi chips and still use the same firmware
image without having to distinguish between the chip drivers.

BUG=b:169802515
BRANCH=zork

Change-Id: Ieac603a970cb2c9bf835021d1fb0fd07fd535280
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46035
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
This commit is contained in:
Furquan Shaikh 2020-10-04 12:52:54 -07:00
parent a1ddd2a15d
commit a266d1e63a
41 changed files with 47 additions and 47 deletions

View File

@ -89,7 +89,7 @@ chip soc/intel/cannonlake
register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 3
end
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi # CNVi wifi
chip drivers/wifi/generic # CNVi wifi
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end
end
@ -141,7 +141,7 @@ chip soc/intel/cannonlake
end
device pci 1c.6 off end # PCI Express Port 7
device pci 1c.7 on # PCI Express Port 8
chip drivers/intel/wifi
chip drivers/wifi/generic
device pci 00.0 on end # x1 M.2/E 2230 (J_WLAN1)
end
register "PcieRpEnable[7]" = "1"

View File

@ -305,7 +305,7 @@ chip soc/intel/jasperlake
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
device pci 14.2 off end # PMC SRAM
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi wifi
end

View File

@ -247,7 +247,7 @@ chip soc/intel/jasperlake
end
end
device pci 1c.7 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW2_03"
device pci 00.0 on end
end

View File

@ -245,7 +245,7 @@ chip soc/intel/tigerlake
device pci 14.1 off end # USB 3.2 1x1 xDCI HC
device pci 14.2 on end # Shared SRAM
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi WiFi
end

View File

@ -328,7 +328,7 @@ chip soc/intel/cannonlake
end
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -380,7 +380,7 @@ chip soc/intel/skylake
end
end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PCI_EXP"
device pci 00.0 on end
end

View File

@ -400,7 +400,7 @@ chip soc/intel/skylake
end
end # PCI Express Port 3
device pci 1c.3 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PCI_EXP"
device pci 00.0 on end
end

View File

@ -118,7 +118,7 @@ chip soc/intel/skylake
device pci 19.1 off end # I2C #5
device pci 19.2 on end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW0_16"
device pci 00.0 on end
end

View File

@ -297,7 +297,7 @@ chip soc/intel/cannonlake
end
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi wifi
end
@ -333,7 +333,7 @@ chip soc/intel/cannonlake
device pci 1d.3 off end # PCI Express Port 12
device pci 1d.4 off end # PCI Express port 13
device pci 1d.5 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW1_01"
device pci 00.0 on end
end

View File

@ -114,7 +114,7 @@ chip soc/intel/apollolake
device pci 00.2 off end # - NPK
device pci 02.0 on end # - Gen
device pci 03.0 on end # - Gaussian Mixture Model (GMM)
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0A_CNVI_PME_STS"
device pci 0c.0 on end # - CNVi
end
@ -136,7 +136,7 @@ chip soc/intel/apollolake
device pci 11.0 off end # - ISH
device pci 12.0 off end # - SATA
device pci 13.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW3_11"
device pci 00.0 on end
end

View File

@ -344,7 +344,7 @@ chip soc/intel/skylake
end
end # I2C #4 - Audio
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW1_07" # GPP_B7
device pci 00.0 on end
end

View File

@ -359,7 +359,7 @@ chip soc/intel/skylake
end # I2C #5
device pci 19.2 on end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW0_00"
device pci 00.0 on end
end

View File

@ -427,7 +427,7 @@ chip soc/intel/skylake
device pci 1c.1 off end # PCI Express Port 2
device pci 1c.2 off end # PCI Express Port 3
device pci 1c.3 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW2_22" # Wake pin = GPP_E22
device pci 00.0 on end
end

View File

@ -388,7 +388,7 @@ chip soc/intel/skylake
end
end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW0_00"
device pci 00.0 on end
end

View File

@ -402,7 +402,7 @@ chip soc/intel/skylake
end
end # I2C #4 - Audio
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW2_01"
device pci 00.0 on end
end

View File

@ -354,7 +354,7 @@ chip soc/intel/skylake
end # I2C #5
device pci 19.2 off end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW0_00" # GPP_B0
device pci 00.0 on end
end

View File

@ -333,7 +333,7 @@ chip soc/intel/skylake
end # I2C #5
device pci 19.2 on end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PCI_EXP"
device pci 00.0 on end
end

View File

@ -147,7 +147,7 @@ chip soc/intel/apollolake
device pci 13.2 off end # - Root Port 4 - PCIe-A 2
device pci 13.3 off end # - Root Port 5 - PCIe-A 3
device pci 14.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW3_00"
device pci 00.0 on end
end

View File

@ -147,7 +147,7 @@ chip soc/intel/apollolake
device pci 13.2 off end # - Root Port 4 - PCIe-A 2
device pci 13.3 off end # - Root Port 5 - PCIe-A 3
device pci 14.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW3_00"
device pci 00.0 on end
end

View File

@ -156,7 +156,7 @@ chip soc/intel/apollolake
device pci 13.2 off end # - Root Port 4 - PCIe-A 2
device pci 13.3 off end # - Root Port 5 - PCIe-A 3
device pci 14.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW3_00"
device pci 00.0 on end
end

View File

@ -143,7 +143,7 @@ chip soc/intel/apollolake
device pci 13.2 off end # - Root Port 4 - PCIe-A 2
device pci 13.3 off end # - Root Port 5 - PCIe-A 3
device pci 14.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW3_00"
device pci 00.0 on end
end

View File

@ -152,7 +152,7 @@ chip soc/intel/apollolake
device pci 13.2 off end # - Root Port 4 - PCIe-A 2
device pci 13.3 off end # - Root Port 5 - PCIe-A 3
device pci 14.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW3_00"
device pci 00.0 on end
end

View File

@ -305,7 +305,7 @@ chip soc/intel/cannonlake
end
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -317,7 +317,7 @@ chip soc/intel/cannonlake
end
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -432,7 +432,7 @@ chip soc/intel/tigerlake
device ref cnvi_bt on end
device ref south_xhci on end
device ref shared_ram on end
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device ref cnvi_wifi on end
end

View File

@ -90,7 +90,7 @@ chip soc/intel/alderlake
end # USB3.1 xHCI
device pci 14.1 off end # USB3.1 xDCI
device pci 14.2 off end # Shared RAM
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi: WiFi
end

View File

@ -94,7 +94,7 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -75,7 +75,7 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -92,7 +92,7 @@ chip soc/intel/cannonlake
register "PcieClkSrcClkReq[10]" = "10"
device domain 0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -61,7 +61,7 @@ chip soc/intel/cannonlake
}"
device domain 0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -80,7 +80,7 @@ chip soc/intel/cannonlake
register "sdcard_cd_gpio" = "GPP_G5"
device domain 0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -65,7 +65,7 @@ chip soc/intel/cannonlake
register "sdcard_cd_gpio" = "GPP_G5"
device domain 0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -280,7 +280,7 @@ chip soc/intel/icelake
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
device pci 14.2 off end # PMC SRAM
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi wifi
end
@ -309,7 +309,7 @@ chip soc/intel/icelake
device pci 19.2 on end # UART #2
device pci 1a.0 on end # eMMC
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PCI_EXP"
device pci 00.0 on end
end

View File

@ -280,7 +280,7 @@ chip soc/intel/icelake
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
device pci 14.2 off end # PMC SRAM
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi wifi
end
@ -309,7 +309,7 @@ chip soc/intel/icelake
device pci 19.2 on end # UART #2
device pci 1a.0 on end # eMMC
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PCI_EXP"
device pci 00.0 on end
end

View File

@ -299,7 +299,7 @@ chip soc/intel/jasperlake
end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG)
device pci 14.2 off end # PMC SRAM
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi wifi
end

View File

@ -243,7 +243,7 @@ chip soc/intel/skylake
end
end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_DW0_16"
device pci 00.0 on end
end

View File

@ -230,7 +230,7 @@ chip soc/intel/tigerlake
device pci 14.0 on end # USB3.1 xHCI 0xA0ED
device pci 14.1 on end # USB3.1 xDCI 0xA0EE
device pci 14.2 on end # Shared RAM 0xA0EF
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi: WiFi 0xA0F0 - A0F3
end

View File

@ -234,7 +234,7 @@ chip soc/intel/tigerlake
device pci 14.0 on end # USB3.1 xHCI 0xA0ED
device pci 14.1 on end # USB3.1 xDCI 0xA0EE
device pci 14.2 on end # Shared RAM 0xA0EF
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end # CNVi: WiFi 0xA0F0 - A0F3
end

View File

@ -166,7 +166,7 @@ chip soc/intel/cannonlake
device pci 02.0 on # Integrated Graphics Device
register "InternalGfx" = "1"
end
chip drivers/intel/wifi
chip drivers/wifi/generic
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end

View File

@ -89,7 +89,7 @@ chip soc/intel/cannonlake
register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 3
end
device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi # CNVi wifi
chip drivers/wifi/generic # CNVi wifi
register "wake" = "GPE0_PME_B0"
device pci 14.3 on end
end
@ -148,7 +148,7 @@ chip soc/intel/cannonlake
register "PcieClkSrcUsage[2]" = "7"
register "PcieClkSrcClkReq[2]" = "2"
register "PcieRpSlotImplemented[7]" = "1"
chip drivers/intel/wifi
chip drivers/wifi/generic
device pci 00.0 on end
end
smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther" "M.2/E 2230 (J_WLAN1)" "SlotDataBusWidth1X"

View File

@ -26,7 +26,7 @@ chip soc/intel/tigerlake
device pci 14.0 alias south_xhci off end
device pci 14.1 alias south_xdci off end
device pci 14.2 alias shared_ram off end
chip drivers/intel/wifi
chip drivers/wifi/generic
device pci 14.3 alias cnvi_wifi off end
end
device pci 15.0 alias i2c0 off end