GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/thread,lib/hardwaremain: Lazy initialize threads 

By lazy initializing the threads, if a stage doesn't use them, they will
be garbage collected.

BUG=b:179699789
TEST=Boot guybrush to the OS and verify threads worked

Suggested-by: Julius Werner <jwerner@chromium.org>
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I7208ffb5dcda63d916bc6cfdea28d92a62435da6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56532
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Raul E Rangel 2021-07-22 11:16:19 -06:00 committed by Patrick Georgi
parent 7db7ee984c
commit a2d83c68a3
3 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/include/thread.h
View File

@ -51,8 +51,6 @@ struct thread {
struct thread_handle *handle; struct thread_handle *handle;
}; };
void threads_initialize(void);
/* Return 0 on successful yield, < 0 when thread did not yield. */ /* Return 0 on successful yield, < 0 when thread did not yield. */
int thread_yield(void); int thread_yield(void);
@ -88,7 +86,6 @@ asmlinkage void switch_to_thread(uintptr_t new_stack, uintptr_t *saved_stack);
void arch_prepare_thread(struct thread *t, void arch_prepare_thread(struct thread *t,
asmlinkage void (*thread_entry)(void *), void *arg); asmlinkage void (*thread_entry)(void *), void *arg);
#else #else
static inline void threads_initialize(void) {}
static inline int thread_yield(void) static inline int thread_yield(void)
{ {
return -1; return -1;

1
src/lib/hardwaremain.c
View File

@ -456,7 +456,6 @@ void main(void)
/* Handoff sleep type from romstage. */ /* Handoff sleep type from romstage. */
acpi_is_wakeup_s3(); acpi_is_wakeup_s3();
threads_initialize();
/* Initialise GNVS early. */ /* Initialise GNVS early. */
if (CONFIG(ACPI_SOC_NVS)) if (CONFIG(ACPI_SOC_NVS))

11
src/lib/thread.c
View File

@ -257,13 +257,16 @@ static void *thread_alloc_space(struct thread *t, size_t bytes)
return (void *)t->stack_current; return (void *)t->stack_current;
} }
void threads_initialize(void) static void threads_initialize(void)
{ {
int i; int i;
struct thread *t; struct thread *t;
u8 *stack_top; u8 *stack_top;
struct cpu_info *ci; struct cpu_info *ci;
if (initialized)
return;
/* `cpu_info()` requires the stacks to be STACK_SIZE aligned */ /* `cpu_info()` requires the stacks to be STACK_SIZE aligned */
assert(IS_ALIGNED((uintptr_t)thread_stacks, CONFIG_STACK_SIZE)); assert(IS_ALIGNED((uintptr_t)thread_stacks, CONFIG_STACK_SIZE));
@ -295,6 +298,9 @@ int thread_run(struct thread_handle *handle, enum cb_err (*func)(void *), void *
struct thread *current; struct thread *current;
struct thread *t; struct thread *t;
/* Lazy initialization */
threads_initialize();
current = current_thread(); current = current_thread();
if (!thread_can_yield(current)) { if (!thread_can_yield(current)) {
@ -327,6 +333,9 @@ int thread_run_until(struct thread_handle *handle, enum cb_err (*func)(void *),
if (!ENV_RAMSTAGE) if (!ENV_RAMSTAGE)
dead_code(); dead_code();
/* Lazy initialization */
threads_initialize();
current = current_thread(); current = current_thread();
if (!thread_can_yield(current)) { if (!thread_can_yield(current)) {