GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google/beltino: fix LED polarity for mccloud variant 

The LED polarity was set incorrectly, fix using values derived
from original Chromium sources:
branch firmware-mccloud-5827.B, ToT
src/mainboard/google/mccloud/smihandler.c
src/mainboard/google/mccloud/romstage.c

TEST: boot google/mccloud, observe power LED on normally,
blinking in S3/S4, and off in S5.

Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/21102
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Matt DeVillier 2017-08-18 14:41:12 -05:00 committed by Martin Roth
parent f15e170de3
commit a2d9afc5ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/beltino/variants/mccloud/led.c
View File

@ -22,7 +22,7 @@ void set_power_led(int state)
it8772f_gpio_led(IT8772F_GPIO_DEV, it8772f_gpio_led(IT8772F_GPIO_DEV,
1, /* set */ 1, /* set */
0x01, /* select */ 0x01, /* select */
state == LED_OFF ? 0x00 : 0x01, /* polarity */ state == LED_BLINK ? 0x01 : 0x00, /* polarity */
state == LED_BLINK ? 0x01 : 0x00, /* pullup/pulldown */ state == LED_BLINK ? 0x01 : 0x00, /* pullup/pulldown */
0x01, /* output */ 0x01, /* output */
state == LED_BLINK ? 0x00 : 0x01, /* I/O function */ state == LED_BLINK ? 0x00 : 0x01, /* I/O function */