From a358f2b4f77868abc6a6d1dfc8062f2210f1c8af Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 26 Mar 2023 16:24:10 -0500 Subject: [PATCH] mb/google/brya: Compile gpio.c in SMM when needed Without gpio.c compiled in, SMMSTORE will fail to initialize and hang. Add a conditional inclusion so gpio.c is compiled in SMM when SMMSTORE is selected. TEST=build/boot google/banshee with SMMSTORE support enabled Change-Id: If049cba98f13f060807058029306dcad2ada2d49 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/74233 Tested-by: build bot (Jenkins) Reviewed-by: Tarun Tuli --- src/mainboard/google/brya/variants/baseboard/brask/Makefile.inc | 2 ++ src/mainboard/google/brya/variants/baseboard/brya/Makefile.inc | 2 ++ src/mainboard/google/brya/variants/baseboard/nissa/Makefile.inc | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/mainboard/google/brya/variants/baseboard/brask/Makefile.inc b/src/mainboard/google/brya/variants/baseboard/brask/Makefile.inc index 8a4b2acfaa..53aaa41148 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/Makefile.inc +++ b/src/mainboard/google/brya/variants/baseboard/brask/Makefile.inc @@ -5,3 +5,5 @@ romstage-y += gpio.c ramstage-y += gpio.c ramstage-y += ramstage.c + +smm-$(CONFIG_SMMSTORE) += gpio.c diff --git a/src/mainboard/google/brya/variants/baseboard/brya/Makefile.inc b/src/mainboard/google/brya/variants/baseboard/brya/Makefile.inc index 8a4b2acfaa..53aaa41148 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/Makefile.inc +++ b/src/mainboard/google/brya/variants/baseboard/brya/Makefile.inc @@ -5,3 +5,5 @@ romstage-y += gpio.c ramstage-y += gpio.c ramstage-y += ramstage.c + +smm-$(CONFIG_SMMSTORE) += gpio.c diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/Makefile.inc b/src/mainboard/google/brya/variants/baseboard/nissa/Makefile.inc index 8a4b2acfaa..53aaa41148 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/Makefile.inc +++ b/src/mainboard/google/brya/variants/baseboard/nissa/Makefile.inc @@ -5,3 +5,5 @@ romstage-y += gpio.c ramstage-y += gpio.c ramstage-y += ramstage.c + +smm-$(CONFIG_SMMSTORE) += gpio.c