GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/nuvoton/npcd378: Fall back to non-negative value 

This change is needed to update the option API to use unsigned integers.
The CMOS option system does not support negative numbers. So, adjust the
call to get_int_option() to use 3 as fallback instead of -1.

Change-Id: I46c5f5c6f47f99379cbafc0d60258b99dc512e9d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52671
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Angel Pons 2021-04-26 16:49:40 +02:00 committed by Felix Held
parent 8580047dfa
commit a35f1810a2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/superio/nuvoton/npcd378/superio.c
View File

@ -68,8 +68,8 @@ static void npcd378_init(struct device *dev)
npcd378_hwm_write_start(res->base); npcd378_hwm_write_start(res->base);
int fan_lvl = get_int_option("psu_fan_lvl", -1); unsigned int fan_lvl = get_int_option("psu_fan_lvl", 3);
if (fan_lvl < 0 || fan_lvl > 7) if (fan_lvl > 7)
fan_lvl = 3; fan_lvl = 3;
uint8_t pwm = NPCD378_HWM_PSU_FAN_MIN + uint8_t pwm = NPCD378_HWM_PSU_FAN_MIN +