GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AMD Family 15tn: Set the default return value as AGESA_SUCCESS instead of TRUE 

The default return value should be AGESA_SUCCESS, which is zero. If it was set as TRUE,
the AGESA wrapper would think it was AGESA_UNSUPPORTED. That would make no sense. And it
would produce ASSERT warning in AGESA wrapper.

On my parmer board, with Engine sample processor, it can not create the correct DMI table.
Routine initlate will return AGESS_ERROR.
------Serial message---------
ASSERTION FAILED: file 'src/mainboard/amd/parmer/agesawrapper.c',  line 427
DmiTable:100123c3, AcpiPstatein: 10010126, AcpiSrat:0,AcpiSlit:0, Mce:100111ba, Cmc:1001127c,Alib:1001ccd4, AcpiIvrs:0 in agesawrapper_amdinitlate
agesawrapper_amdinitlate failed: 5
-----------------------------
I believe the processor with acceptable name string will create the right DMI.

Change-Id: Ie86955cf9affffc964a7c9f4a2c63077ef2030de
Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Signed-off-by: zbao <fishbaozi@gmail.com>
Reviewed-on: http://review.coreboot.org/1350
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
zbao 2012-07-24 17:58:30 +08:00 committed by Ronald G. Minnich
parent 19a185448a
commit a36d8b38a6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c
View File

@ -245,7 +245,7 @@ GetDmiInfoMain (
CPU_GET_MEM_INFO CpuGetMemInfo; CPU_GET_MEM_INFO CpuGetMemInfo;
MsrData = 0; MsrData = 0;
Flag = TRUE; Flag = AGESA_SUCCESS;
ProcData = NULL; ProcData = NULL;
MemInfo = NULL; MemInfo = NULL;
DmiBufferPtr = *DmiTable; DmiBufferPtr = *DmiTable;
@ -473,7 +473,7 @@ GetType4Type7Info (
PROC_FAMILY_TABLE *ProcData; PROC_FAMILY_TABLE *ProcData;
CPU_LOGICAL_ID LogicalID; CPU_LOGICAL_ID LogicalID;
Flag = TRUE; Flag = AGESA_SUCCESS;
DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock; DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock;
GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader); GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader);