GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google/glados: configure gpio pads prior to SiliconInit() 

Move the gpio pad configuration prior to SiliconInit()
in case there are dependencies of the pads being configured
in prior to SiliconInit().

BUG=chrome-os-partner:43522
BUG=chrome-os-partner:43492
BRANCH=None
TEST=Built and booted glados.

Change-Id: I84f8e965bf205a4945b14a63fa8074953750f785
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Original-Commit-Id: 5cce5347449f69ac6cf7030ea3b91d3f8b4cc7f9
Original-Change-Id: I18cd33a455d5635a866abb76142cab516b04f446
Original-Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/294642
Original-Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: http://review.coreboot.org/11420
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Aaron Durbin 2015-08-20 13:06:56 -05:00 committed by Patrick Georgi
parent 31718c039f
commit a3fa98a5d7
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/glados/mainboard.c
View File

@ -22,12 +22,9 @@
#include <device/device.h> #include <device/device.h>
#include <stdlib.h> #include <stdlib.h>
#include "ec.h" #include "ec.h"
#include "gpio.h"
static void mainboard_init(device_t dev) static void mainboard_init(device_t dev)
{ {
gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table));
if (IS_ENABLED(CONFIG_GOOGLE_CHROME_EC)) if (IS_ENABLED(CONFIG_GOOGLE_CHROME_EC))
mainboard_ec_init(); mainboard_ec_init();
} }

4
src/mainboard/google/glados/ramstage.c
View File

@ -19,7 +19,11 @@
*/ */
#include <soc/ramstage.h> #include <soc/ramstage.h>
#include "gpio.h"
void mainboard_silicon_init_params(SILICON_INIT_UPD *params) void mainboard_silicon_init_params(SILICON_INIT_UPD *params)
{ {
/* Configure pads prior to SiliconInit() in case there's any
* dependencies during hardware initialization. */
gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table));
} }