nb/intel/x4x: Put stage cache in TSEG
TSEG is not accessible in ring 0 after it is locked in ramstage, in contrast with cbmem which remains accessible. Assuming SMM does not touch the cache this is a good region to cache stages. Tested on Intel DG41WV, the stage cache gets properly created and used on S3 resume. Change-Id: Ie46c1416f8042d5571339b36e1253c0cae0684b8 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/25606 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
20f71369d9
commit
a402a9e7ab
|
@ -30,6 +30,7 @@ config NORTHBRIDGE_SPECIFIC_OPTIONS # dummy
|
||||||
select POSTCAR_CONSOLE
|
select POSTCAR_CONSOLE
|
||||||
select SMM_TSEG
|
select SMM_TSEG
|
||||||
select PARALLEL_MP
|
select PARALLEL_MP
|
||||||
|
select CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
|
||||||
|
|
||||||
config CBFS_SIZE
|
config CBFS_SIZE
|
||||||
hex
|
hex
|
||||||
|
@ -47,4 +48,8 @@ config MMCONF_BASE_ADDRESS
|
||||||
hex
|
hex
|
||||||
default 0xe0000000
|
default 0xe0000000
|
||||||
|
|
||||||
|
config SMM_RESERVED_SIZE
|
||||||
|
hex
|
||||||
|
default 0x100000
|
||||||
|
|
||||||
endif
|
endif
|
||||||
|
|
|
@ -30,5 +30,8 @@ ramstage-y += gma.c
|
||||||
ramstage-y += northbridge.c
|
ramstage-y += northbridge.c
|
||||||
|
|
||||||
postcar-y += ram_calc.c
|
postcar-y += ram_calc.c
|
||||||
|
romstage-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += stage_cache.c
|
||||||
|
ramstage-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += stage_cache.c
|
||||||
|
postcar-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += stage_cache.c
|
||||||
|
|
||||||
endif
|
endif
|
||||||
|
|
|
@ -0,0 +1,32 @@
|
||||||
|
/*
|
||||||
|
* This file is part of the coreboot project.
|
||||||
|
*
|
||||||
|
* Copyright 2015 Google, Inc.
|
||||||
|
*
|
||||||
|
* This program is free software; you can redistribute it and/or modify
|
||||||
|
* it under the terms of the GNU General Public License as published by
|
||||||
|
* the Free Software Foundation; version 2 of the License.
|
||||||
|
*
|
||||||
|
* This program is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
* GNU General Public License for more details.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <arch/io.h>
|
||||||
|
#include <cbmem.h>
|
||||||
|
#include <device/pci.h>
|
||||||
|
#include <stage_cache.h>
|
||||||
|
#include <cpu/intel/smm/gen1/smi.h>
|
||||||
|
#include "x4x.h"
|
||||||
|
|
||||||
|
void stage_cache_external_region(void **base, size_t *size)
|
||||||
|
{
|
||||||
|
/*
|
||||||
|
* The ramstage cache lives in the TSEG region at RESERVED_SMM_OFFSET.
|
||||||
|
* The top of RAM is defined to be the TSEG base address.
|
||||||
|
*/
|
||||||
|
*size = CONFIG_SMM_RESERVED_SIZE;
|
||||||
|
*base = (void *)(northbridge_get_tseg_base()
|
||||||
|
+ CONFIG_SMM_RESERVED_SIZE);
|
||||||
|
}
|
Loading…
Reference in New Issue