mrc_cache: Remove unnecessary data checksum calculation
When MRC_SAVE_HASH_IN_TPM is selected, we can just use the TPM hash to verify the MRC_CACHE data. Thus, we don't need to calculate the checksum anymore in this case. BUG=b:150502246 BRANCH=None TEST=make sure memory training still works on nami Change-Id: I1db4469da49755805b541f50c7ef2f9cdb749425 Signed-off-by: Shelley Chen <shchen@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46515 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
parent
c1040f3ef4
commit
a45f8959c0
1 changed files with 12 additions and 11 deletions
|
@ -193,18 +193,19 @@ static int mrc_data_valid(int type, const struct mrc_metadata *md,
|
||||||
if (md->data_size != data_size)
|
if (md->data_size != data_size)
|
||||||
return -1;
|
return -1;
|
||||||
|
|
||||||
checksum = compute_ip_checksum(data, data_size);
|
|
||||||
|
|
||||||
if (md->data_checksum != checksum) {
|
|
||||||
printk(BIOS_ERR, "MRC: data checksum mismatch: %x vs %x\n",
|
|
||||||
md->data_checksum, checksum);
|
|
||||||
return -1;
|
|
||||||
}
|
|
||||||
|
|
||||||
hash_idx = cr->tpm_hash_index;
|
hash_idx = cr->tpm_hash_index;
|
||||||
if (hash_idx && CONFIG(MRC_SAVE_HASH_IN_TPM) &&
|
if (hash_idx && CONFIG(MRC_SAVE_HASH_IN_TPM)) {
|
||||||
!mrc_cache_verify_hash(hash_idx, data, data_size))
|
if (!mrc_cache_verify_hash(hash_idx, data, data_size))
|
||||||
return -1;
|
return -1;
|
||||||
|
} else {
|
||||||
|
checksum = compute_ip_checksum(data, data_size);
|
||||||
|
|
||||||
|
if (md->data_checksum != checksum) {
|
||||||
|
printk(BIOS_ERR, "MRC: data checksum mismatch: %x vs %x\n",
|
||||||
|
md->data_checksum, checksum);
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue