GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/bd82x6x/early_usb: Add USB TX/RX gains 

Describe the USB 'current' settings based on MRC.bin that converts
the USB trace length to a predefined register value.
MRC.bin decides which setting to use based on the PC type, mobile
or desktop, and the trace length.

Tested:	Lenovo X220 still boots.

Change-Id: I79d35ca16818daec03ee7f464349a4c8ee0f78e4
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78829
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Patrick Rudolph 2023-10-31 16:50:05 +01:00 committed by Lean Sheng Tan
parent d323d844f7
commit a48debdaa0
2 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/southbridge/intel/bd82x6x/early_usb.c
View File

@ -16,26 +16,27 @@ void early_usb_init(const struct southbridge_usb_port *portmap)
/* 3560 */ 0x024c8001, 0x000024a3, 0x00040002, 0x01000050, /* 3560 */ 0x024c8001, 0x000024a3, 0x00040002, 0x01000050,
/* 3570 */ 0x02000772, 0x16000f9f, 0x1800ff4f, 0x0001d630, /* 3570 */ 0x02000772, 0x16000f9f, 0x1800ff4f, 0x0001d630,
}; };
const u32 currents[] = { 0x20000153, 0x20000f57, 0x2000055b, 0x20000f51, const u32 currents[] = { USBIR_TXRX_GAIN_MOBILE_LOW, USBIR_TXRX_GAIN_DEFAULT,
0x2000094a, 0x2000035f, 0x20000f53, 0x20000357, USBIR_TXRX_GAIN_HIGH, 0x20000f51, 0x2000094a, 0x2000035f,
0x20000353 }; USBIR_TXRX_GAIN_DESKTOP_LOW, 0x20000357, 0x20000353 };
int i; int i;
/* Unlock registers. */ /* Unlock registers. */
write_pmbase16(UPRWC, read_pmbase16(UPRWC) | UPRWC_WR_EN); write_pmbase16(UPRWC, read_pmbase16(UPRWC) | UPRWC_WR_EN);
for (i = 0; i < 14; i++) { for (i = 0; i < 14; i++) {
if (portmap[i].enabled && !pch_is_mobile() && portmap[i].current == 0) { if (portmap[i].enabled && !pch_is_mobile() &&
currents[portmap[i].current] == USBIR_TXRX_GAIN_MOBILE_LOW) {
/* /*
* Note for developers: You can fix this by re-running autoport on * Note for developers: You can fix this by re-running autoport on
* vendor firmware and then updating portmap currents accordingly. * vendor firmware and then updating portmap currents accordingly.
* If that is not possible, another option is to choose a non-zero * If that is not possible, another option is to choose a non-zero
* current setting. In either case, please test all the USB ports. * current setting. In either case, please test all the USB ports.
*/ */
printk(BIOS_ERR, "%s: USB%02d: current setting of 0 is an invalid setting for desktop!\n", printk(BIOS_ERR, "%s: USB%02d: USBIR_TXRX_GAIN_MOBILE_LOW is an invalid setting for desktop!\n",
__func__, i); __func__, i);
RCBA32(USBIR0 + 4 * i) = currents[1]; RCBA32(USBIR0 + 4 * i) = USBIR_TXRX_GAIN_DEFAULT;
} else { } else {
RCBA32(USBIR0 + 4 * i) = currents[portmap[i].current]; RCBA32(USBIR0 + 4 * i) = currents[portmap[i].current];
} }

12
src/southbridge/intel/bd82x6x/pch.h
View File

@ -382,6 +382,18 @@ void early_usb_init(const struct southbridge_usb_port *portmap);
#define USBIR12 0x3530 /* 32bit */ #define USBIR12 0x3530 /* 32bit */
#define USBIR13 0x3534 /* 32bit */ #define USBIR13 0x3534 /* 32bit */
/* Up to 5" onboard trace length */
#define USBIR_TXRX_GAIN_MOBILE_LOW 0x20000153
/* Up to 6" onboard trace length */
#define USBIR_TXRX_GAIN_DESKTOP_LOW 0x20000F53
/* Up to 14" onboard trace length, up to 8" on wires */
#define USBIR_TXRX_GAIN_DEFAULT 0x20000f57
/* Up to 10" onboard trace length, up to 15" on wires */
#define USBIR_TXRX_GAIN_HIGH 0x2000055B
/* Miscellaneous Control Register */ /* Miscellaneous Control Register */
#define MISCCTL 0x3590 /* 32bit */ #define MISCCTL 0x3590 /* 32bit */
/* USB Port Disable Override */ /* USB Port Disable Override */