GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

board_status.sh: trivial cosmetic changes toward the end 

This moves an ugly comment closer to where it is applicable and also
adds a visual break between the commands which gather data and the
part of the script that finishes up. I'm usually not fan of banner
comments, but it seemed to help in my totally subjective opinion.

I was thinking about how to break the part that uploads results into
a separate function, but there are enough variables that are re-used
from earlier parts that the tradeoff probably isn't worth it.

Change-Id: If888329911c4de3b907cdf5973695c707bbb02fe
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/4051
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
David Hendricks 2013-11-12 18:17:19 -08:00
parent 406ce8a06e
commit a4affe17f1
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
util/board_status/board_status.sh
View File

@ -174,8 +174,9 @@ cmd_nonfatal $REMOTE "cbmem -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt" cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
# FIXME: the board-status directory might get big over time. Is there a way we #
# can push the results without fetching the whole repo? # Finish up.
#
coreboot_dir=`pwd` coreboot_dir=`pwd`
if [ $UPLOAD_RESULTS -eq 1 ]; then if [ $UPLOAD_RESULTS -eq 1 ]; then
# extract username from ssh://<username>@review.coreboot.org/blah # extract username from ssh://<username>@review.coreboot.org/blah
@ -183,6 +184,9 @@ if [ $UPLOAD_RESULTS -eq 1 ]; then
cd "util/board_status/" cd "util/board_status/"
if [ ! -e "board-status" ]; then if [ ! -e "board-status" ]; then
# FIXME: the board-status directory might get big over time.
# Is there a way we can push the results without fetching the
# whole repo?
git clone "ssh://${username}@review.coreboot.org:29418/board-status" git clone "ssh://${username}@review.coreboot.org:29418/board-status"
if [ $? -ne 0 ]; then if [ $? -ne 0 ]; then
"Error cloning board-status repo, aborting." "Error cloning board-status repo, aborting."