GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload/libc: Fix memset/sizeof usage 

Since r is a pointer, memset(r, 0, sizeof(r)) would only zero the first
4 (or 8) bytes of the newly allocated struct align_region_t.

An alternative to this patch would be to use calloc, or introduce a new
zalloc (zeroed allocation; a single-element calloc) and use that.

Change-Id: Ic3e3487ce749eeebf6c4836e62b8a305ad766e7e
Found-by: Coverity (ID 1291160)
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-on: https://review.coreboot.org/14244
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Jonathan Neuschäfer 2016-04-05 21:36:34 +02:00 committed by Nico Huber
parent 2fff2a6e31
commit a4fbc385e0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
payloads/libpayload/libc/malloc.c
View File

@ -366,7 +366,7 @@ static struct align_region_t *allocate_region(int alignment, int num_elements,
if (r == NULL) if (r == NULL)
return NULL; return NULL;
memset(r, 0, sizeof(r)); memset(r, 0, sizeof(*r));
if (num_elements != 0) { if (num_elements != 0) {
r->alignment = alignment; r->alignment = alignment;