GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim/var/frostflow: Fix USB port ACPI generation 

The overridetree definitions for the USB ports wrongly double-nested
the ports, causing the generated SSDT to be incorrect, leading to
an error in dmesg:

ACPI BIOS error (bug): Could not resolve symbol \
  [\_SB.PCI0.GP41.XHC1.RHUB.HS02.HS03], AE_NOT_FOUND

BUG=b:283778468
BRANCH=skyrim
TEST=build/boot frostflow, verify error no longer present in dmesg.

Change-Id: I0b87af6b2c04f9354e6f394a8f987fa660e49134
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75338
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
This commit is contained in:
Matt DeVillier 2023-05-18 16:11:59 -05:00 committed by Felix Held
parent cf993bd343
commit a539893cee
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/mainboard/google/skyrim/variants/frostflow/overridetree.cb
View File

@ -32,24 +32,18 @@ chip soc/amd/mendocino
device ref xhci_1_root_hub on # XHCI1 root hub device ref xhci_1_root_hub on # XHCI1 root hub
chip drivers/usb/acpi chip drivers/usb/acpi
device ref usb3_port3 on # USB 3.1 port3 device ref usb3_port3 on # USB 3.1 port3
chip drivers/usb/acpi register "desc" = ""USB3 Type-A Port A1 (DB)""
register "desc" = ""USB3 Type-A Port A1 (DB)"" register "type" = "UPC_TYPE_USB3_A"
register "type" = "UPC_TYPE_USB3_A" register "use_custom_pld" = "true"
register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))"
register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))"
device usb 3.2 on end
end
end # USB 3.1 port3 end # USB 3.1 port3
end end
chip drivers/usb/acpi chip drivers/usb/acpi
device ref usb2_port3 on # USB 2 port3 device ref usb2_port3 on # USB 2 port3
chip drivers/usb/acpi register "desc" = ""USB2 Type-A Port A1 (DB)""
register "desc" = ""USB2 Type-A Port A1 (DB)"" register "type" = "UPC_TYPE_USB3_A"
register "type" = "UPC_TYPE_USB3_A" register "use_custom_pld" = "true"
register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))"
register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))"
device usb 2.2 on end
end
end # USB 2 port3 end # USB 2 port3
end end
end # XHCI1 root hub end # XHCI1 root hub