GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/hp/kbc1126: Wait a longer time after sending 

This fixes the fan always running at full speed on ProBook 6360b,
EliteBook 8470p and ProBook 640 G1 (because the fan control command was
not sent).

On the ProBook 6360b, the EC needs about 30 ms to process the first
command on a cold boot, but other models such as the ProBook 640 G1 need
more time.

Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Signed-off-by: Pablo Stebler <pablo@stebler.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44750
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Pablo Stebler 2020-08-25 11:22:19 +02:00 committed by Nico Huber
parent 19dd694401
commit a5ce4d3e68
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ec/hp/kbc1126/ec.c
View File

@ -24,7 +24,7 @@ static int send_kbd_command(u8 command)
{ {
int timeout; int timeout;
timeout = 0x7ff; timeout = 100000; /* 1 second */
while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) { while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) {
udelay(10); udelay(10);
if ((timeout & 0xff) == 0) if ((timeout & 0xff) == 0)
@ -44,7 +44,7 @@ static int send_kbd_data(u8 data)
{ {
int timeout; int timeout;
timeout = 0x7ff; timeout = 100000; /* 1 second */
while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) { /* wait for IBF = 0 */ while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) { /* wait for IBF = 0 */
udelay(10); udelay(10);
if ((timeout & 0xff) == 0) if ((timeout & 0xff) == 0)