From a626d2ed6f15748f40500cef1ec074ed9fd785df Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Thu, 21 Jan 2021 13:59:28 -0700 Subject: [PATCH] soc/amd/common/acpi: Add _UID for PNP0C02 devices When MAINBOARD_HAS_SPEAKER is false, the SPKR gets _HID PNP0C02. This conflicts with the LDRC device. PNP0C02 is also used other places in the picasso code base, so I chose a random _UID for each device. The _UIDs are unique in the code base so it's easy to search for duplicates. BUG=b:175146875 TEST=Boot trembyle to linux Signed-off-by: Raul E Rangel Change-Id: I01be41515e011293e90a6b42b8e34de8ec3ffc18 Reviewed-on: https://review.coreboot.org/c/coreboot/+/49813 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/soc/amd/common/acpi/lpc.asl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/soc/amd/common/acpi/lpc.asl b/src/soc/amd/common/acpi/lpc.asl index d2224e8f13..254fc69793 100644 --- a/src/soc/amd/common/acpi/lpc.asl +++ b/src/soc/amd/common/acpi/lpc.asl @@ -22,6 +22,7 @@ Device(LPCB) { Device(LDRC) // LPC device: Resource consumption { Name (_HID, EISAID("PNP0C02")) // ID for Motherboard resources + Name (_UID, 0x3278) Name (CRS, ResourceTemplate () // Current Motherboard resources { Memory32Fixed(ReadWrite, // Setup for fixed resource location for SPI base address @@ -68,6 +69,7 @@ Device(LPCB) { Device(SPKR) { /* Speaker */ Name(_HID,EISAID(IO61_HID)) + Name (_UID, 0x7239) Name(_CRS, ResourceTemplate() { IO(Decode16, 0x0061, 0x0061, 0, 1) })