From a63fac3c58951e9cbbc9a25f03841d75e4fe7ec2 Mon Sep 17 00:00:00 2001 From: Fred Reitberger Date: Mon, 13 Feb 2023 11:06:15 -0500 Subject: [PATCH] soc/amd/common: Move missing APCB warning to common area Move missing APCB warning from birman to amd/common so that other mainboards can utilize the same warnings if the APCB is missing. Signed-off-by: Fred Reitberger Change-Id: I7ae689726ae4f7ccdf6959e47cbb5aee15cdb690 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73002 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth Reviewed-by: Matt DeVillier Reviewed-by: Felix Held --- src/mainboard/amd/birman/Makefile.inc | 6 ------ src/soc/amd/common/Makefile.inc | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mainboard/amd/birman/Makefile.inc b/src/mainboard/amd/birman/Makefile.inc index a19cb35392..6255ff07c7 100644 --- a/src/mainboard/amd/birman/Makefile.inc +++ b/src/mainboard/amd/birman/Makefile.inc @@ -17,12 +17,6 @@ else files_added:: warn_no_apcb endif -PHONY+=warn_no_apcb -warn_no_apcb: - printf "\n\t** WARNING **\n" - printf "coreboot has been built without an APCB.\n" - printf "This image will not boot.\n\n" - ifeq ($(CONFIG_BIRMAN_HAVE_MCHP_FW),y) $(call add_intermediate, add_mchp_fw) $(CBFSTOOL) $(obj)/coreboot.pre write -r EC -f $(CONFIG_BIRMAN_MCHP_SIG_FILE) --fill-upward diff --git a/src/soc/amd/common/Makefile.inc b/src/soc/amd/common/Makefile.inc index 1c145128c3..a72f0dc706 100644 --- a/src/soc/amd/common/Makefile.inc +++ b/src/soc/amd/common/Makefile.inc @@ -49,4 +49,10 @@ endif # ifneq ($(CONFIG_AMDFW_CONFIG_FILE), ) MAINBOARD_BLOBS_DIR := $(call strip_quotes, $(CONFIG_APCB_BLOBS_DIR)) +PHONY+=warn_no_apcb +warn_no_apcb: + printf "\n\t** WARNING **\n" + printf "coreboot has been built without an APCB.\n" + printf "This image will not boot.\n\n" + endif # ifeq ($(CONFIG_SOC_AMD_COMMON),y)